Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load RELab spectral Library #158

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Load RELab spectral Library #158

wants to merge 3 commits into from

Conversation

YannChemin
Copy link

No description provided.

@tboggs
Copy link
Member

tboggs commented Oct 16, 2023

Hi,

Thanks for the PR. Could you please make the PR against the develop branch so I can test it prior to merging into master? Also, can you please provide any details about the code like:

  • Does it handle all attributes of the RELab library?
  • Are there any issues/limitations to how it works?
  • Is there any clean-up that still needs to be done (e.g., it looks like the bad_files list may not be relvant here)?

Thanks,
Thomas

@YannChemin
Copy link
Author

done, plz check the #160

@YannChemin
Copy link
Author

Hi, have you been able to test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@YannChemin @tboggs