Parameterize build branches #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerGillson
requested changes
Dec 20, 2023
oz123
force-pushed
the
paramertrize-build-branches
branch
2 times, most recently
from
3f753f8
to
3882239
Compare
If I want to merge a branch into the two-node brach, I should be able to test that branch, hence I should build from that branch. Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
This allows merging changes to the test script without risking git merge havoc if these are overriden in the script. Also, it prevents people from accidentally commiting secrets. Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
This allows running the script from the test dir and also any other path (e.g. top dir of the repo) Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
oz123
force-pushed
the
paramertrize-build-branches
branch
from
8fea35c
to
3d65bea
Compare
Also, used explicit RUN command for each shell line Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
…/CanvOS into paramertrize-build-branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.