Add luacheck action and fix linting warnings #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
This PR is a proposal
I fixed here the most "obvious" warnings/errors, ensured
qrtest.lua
still reported no error, and also checked a few QR codes I had previously generated withqrcode.lua
were unchanged.As of this initial PR, though, I have left two warnings unaddressed (in the same portion of code): I am unsure what the loop there does exactly and whether this might hint toward some small logic error possibly - So I preferred not silencing them. Please feel free to check and comment.
(for that reason, I haven't proposed adding a Luacheck badge to the README, since it still fails for now)