Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add luacheck action and fix linting warnings #8

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

Omikhleia
Copy link
Contributor

@Omikhleia Omikhleia commented Dec 10, 2022

Greetings,
This PR is a proposal

  • fixing several linting warnings or errors
  • adding a GitHub action (= CI pipeline) to the repository, so that to ensure linting checks are performed automatically when changed are pushed.

I fixed here the most "obvious" warnings/errors, ensured qrtest.lua still reported no error, and also checked a few QR codes I had previously generated with qrcode.lua were unchanged.

As of this initial PR, though, I have left two warnings unaddressed (in the same portion of code): I am unsure what the loop there does exactly and whether this might hint toward some small logic error possibly - So I preferred not silencing them. Please feel free to check and comment.

(for that reason, I haven't proposed adding a Luacheck badge to the README, since it still fails for now)

@Omikhleia
Copy link
Contributor Author

Omikhleia commented Dec 10, 2022

I could have added a link to the above-mentioned unaddressed lint warnings:
https://github.com/Omikhleia/luaqrcode/actions/runs/3664504028/jobs/6194957626

@pgundlach
Copy link
Member

Thank you very much. I will take a look at it and report back.

Copy link
Member

@pgundlach pgundlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me.

@pgundlach pgundlach merged commit fac5482 into speedata:master Dec 12, 2022
@pgundlach
Copy link
Member

I hope I have merged this correctly. I am not an expert using GitHub and its actions. Thank you very much for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants