Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fault_injection_fs: avoid division by zero in DropRandomUnsyncedData() #15

Closed
Yuval-Ariel opened this issue Jun 16, 2022 · 0 comments · Fixed by #17
Closed

fault_injection_fs: avoid division by zero in DropRandomUnsyncedData() #15

Yuval-Ariel opened this issue Jun 16, 2022 · 0 comments · Fixed by #17
Assignees
Labels
bug Something isn't working Upstreamable can be upstreamed to RocksDB

Comments

@Yuval-Ariel
Copy link
Contributor

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.

@Yuval-Ariel Yuval-Ariel added the bug Something isn't working label Jun 16, 2022
@Yuval-Ariel Yuval-Ariel added the Upstreamable can be upstreamed to RocksDB label Jun 20, 2022
Yuval-Ariel added a commit that referenced this issue Jun 23, 2022
…ision-by-zero-in-droprandomunsynceddata

#15 SPDB-720: fault_injection_fs: avoid division by zero in DropRandomUns…
Yuval-Ariel added a commit that referenced this issue Jun 23, 2022
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
isaac-io pushed a commit that referenced this issue Oct 19, 2022
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
Yuval-Ariel added a commit that referenced this issue Nov 23, 2022
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
Yuval-Ariel added a commit that referenced this issue Apr 30, 2023
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
udi-speedb pushed a commit that referenced this issue Oct 29, 2023
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
udi-speedb pushed a commit that referenced this issue Dec 1, 2023
…Data()

When there's no data in the buffer, there's nothing to drop anyway, and
providing 0 to the rand->Uniform() function results in a division by zero
error (SIGFPE), so just check and do nothing in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Upstreamable can be upstreamed to RocksDB
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants