Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mechanism for saving and reading Options in other string formats (like JSON or XML) #379

Open
mrambacher opened this issue Jan 26, 2023 · 4 comments
Labels
enhancement New feature or request To review A feature request that has not been reviewed yet

Comments

@mrambacher
Copy link
Contributor

Currently, Options are stored in a file in something similar to a Properties file format, where there is a label and the name=value pairs on separate lines. Sets of options can also be passed to the ConfigureFromString method (";" separated name-value pairs) and converted to strings (delimiter separated name-value pairs).

This issue requests that we support other formats, such as JSON or XML. These other formats may be more widely known and could be easier to generate from or consumed by external tools.

For the Configure piece, this is mostly writing a different implementation of StringToMap. There is likely another method needed on the Serialize side (to store values in a map that can be converted to a string, rather than as a string directly).

Note that RocksDB users such as topling db have something similar, but it is more of an "add-on" rather than "integrated" functionality.

@Guyme
Copy link

Guyme commented Oct 30, 2023

@mrambacher - is this connected to a specific PR ?
Please consolidate or add a PR

@mrambacher
Copy link
Contributor Author

@Guyme There is no ability at this point to write an options file to JSON or XML format. The code to support writing Options to different formats is part of #692 and #719, but there is no work currently to support XML or JSON and the format of the Options file is not changed.

@udi-speedb
Copy link
Contributor

@mrambacher - Is this pr required for #430 ?

@mrambacher
Copy link
Contributor Author

N

@mrambacher - Is this pr required for #430 ?

No, #719 is required for #430, but other formats like JSON and XML are not required. And there is the possibility that #719 is not in itself adequate to address this issue (though it is a good start).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request To review A feature request that has not been reviewed yet
Projects
Status: 📖 Need your Opinion!
Development

No branches or pull requests

4 participants