Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static Pinning: Report the policy type and applicable parameters to the Log #691

Closed
udi-speedb opened this issue Sep 27, 2023 · 2 comments · Fixed by #707
Closed

Static Pinning: Report the policy type and applicable parameters to the Log #691

udi-speedb opened this issue Sep 27, 2023 · 2 comments · Fixed by #707
Assignees
Labels
enhancement New feature or request usability

Comments

@udi-speedb
Copy link
Contributor

The type of pinning policy should be reported to the log.
In addition, when using scoped pinning policy, we should also print the policy's configuration (capacity, last level percent, mid percent)

@udi-speedb udi-speedb added enhancement New feature or request usability labels Sep 27, 2023
@mrambacher
Copy link
Contributor

This would happen automatically (with no further code change) when the PinningPolicy is part of the configurable table options (#690) and the Options code is used to write the data to the log file (#379, #692).

@udi-speedb
Copy link
Contributor Author

Well, having a generic mechanism that takes care of that is wonderful, but we are not there yet. However, the feature is in the repo already. The code to support this is trivial. I prefer that people would be able to see the values when using the feature rather than wait for the future mechanism to support it generically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants