Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Source Documentation: We should update the contributing guide #713

Closed
udi-speedb opened this issue Oct 12, 2023 · 2 comments · Fixed by #744
Closed

Open Source Documentation: We should update the contributing guide #713

udi-speedb opened this issue Oct 12, 2023 · 2 comments · Fixed by #744
Assignees

Comments

@udi-speedb
Copy link
Contributor

We have decided that any existing file that we modify should have the following license text at its top, before the Facebook's license text:

// Copyright (C) 2023 Speedb Ltd. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
//   http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

The CONTIRBUTING.md file needs to be updated to reflect that.

@mrambacher
Copy link
Contributor

Why did we decide that? Now any file an external updates must also have a Speedb copyright (in addition to Meta/Facebook? Which part of the file is copyright speedb and which part Meta?

@udi-speedb
Copy link
Contributor Author

@mrambacher - This question should be addressed to @Guyme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants