120 qa tool for testing the artifacts #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuval-Ariel
reviewed
Nov 15, 2022
tools/artifacts_check/Makefile
Outdated
| all: check_static check_shared | ||
|
|
||
| check_static: check_artifacts.cc | ||
| $(CXX) $(CXXFLAGS) check_artifacts.cc -o$@ ../../libspeedb.a -I../../include -O2 -std=c++17 $(PLATFORM_LDFLAGS) $(PLATFORM_CXXFLAGS) $(EXEC_LDFLAGS) |
There was a problem hiding this comment.
the -O2 optimize level is used only when DEBUG_LEVEL=2. why are we using it here?
Yuval-Ariel
approved these changes
Nov 20, 2022
RoyBenMoshe
force-pushed
the
120_QA_tool_for_testing_the_artifacts
branch
from
ea5dd06
to
88eda6f
Compare
RoyBenMoshe
force-pushed
the
120_QA_tool_for_testing_the_artifacts
branch
from
88eda6f
to
3080bdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.