Support running enabled speedb feature check in CI #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayulas
requested review from
ofriedma and
autogit-speedb
and removed request for
autogit-speedb
mrambacher
reviewed
Oct 18, 2023
|
@ayulas - Could you please describe what issues you have found and how they were found? Thanks |
|
@ayulas - Please describe what's the status of this pr. |
ayulas
force-pushed
the
723-support-enable-speedb-features-in-ci
branch
2 times, most recently
from
02129f6
to
fbf0b97
Compare
|
@ofriedma pls approve |
ayulas
force-pushed
the
723-support-enable-speedb-features-in-ci
branch
from
fbf0b97
to
c2280b5
Compare
ofriedma
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Beside other comments there is a gap I'm currently working on in the db_bench, which enable speedb features is overriding other flags the user explicitly write, so there could be other tests running defacto although the user didn't mean to.
To avoid duplicate both PRs, I'm suggesting after I will find all those conflicts in the db_bench code, to complete/resume this PR.
@ayulas please tell me what you think
ayulas
force-pushed
the
723-support-enable-speedb-features-in-ci
branch
6 times, most recently
from
5f8ef3b
to
413fb50
Compare
ayulas
force-pushed
the
723-support-enable-speedb-features-in-ci
branch
from
413fb50
to
2a608e0
Compare
ofriedma
approved these changes
Nov 12, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 19, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Nov 23, 2023
udi-speedb
pushed a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.