stress test: Disable IsDone assertion which fails with tracing sometimes - #816
Merged
Conversation
udi-speedb
previously approved these changes
Jan 24, 2024
udi-speedb
previously approved these changes
Jan 24, 2024
udi-speedb
previously approved these changes
Jan 25, 2024
Yuval-Ariel
force-pushed
the
yuval/disable-tracing-with-use-txn
branch
from
January 28, 2024 06:48
235b57e to
20c3c9e
Compare
Yuval-Ariel
changed the title
Yuval-Ariel
force-pushed
the
yuval/disable-tracing-with-use-txn
branch
from
January 28, 2024 12:06
20c3c9e to
c5fbf43
Compare
Contributor
Author
|
@udi-speedb rebased on main with zlib fix. |
udi-speedb
previously approved these changes
Jan 28, 2024
udi-speedb
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be reverted once #813 is handled
Adding a trace file by default in #797 has revealed some incompatibilities between the trace file and several configurations (more details in #813).
Keep the trace file and remove the IsDone assertion.