Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stress test: Disable IsDone assertion which fails with tracing sometimes #816

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Yuval-Ariel
Copy link
Contributor

@Yuval-Ariel Yuval-Ariel commented Jan 24, 2024

This should be reverted once #813 is handled

Adding a trace file by default in #797 has revealed some incompatibilities between the trace file and several configurations (more details in #813).
Keep the trace file and remove the IsDone assertion.

udi-speedb
udi-speedb previously approved these changes Jan 24, 2024
udi-speedb
udi-speedb previously approved these changes Jan 24, 2024
udi-speedb
udi-speedb previously approved these changes Jan 25, 2024
@Yuval-Ariel Yuval-Ariel force-pushed the yuval/disable-tracing-with-use-txn branch from 235b57e to 20c3c9e Compare January 28, 2024 06:48
@Yuval-Ariel Yuval-Ariel changed the title stress test: Disable tracing with use_txn stress test: Disable IsDone assertion which fails with tracing sometimes Jan 28, 2024
Adding a trace file by default in PR #797 has revealed some incompatibilities between the trace file and several configurations (more details in #813). Keep the trace file and remove the IsDone assertion.
@Yuval-Ariel Yuval-Ariel force-pushed the yuval/disable-tracing-with-use-txn branch from 20c3c9e to c5fbf43 Compare January 28, 2024 12:06
@Yuval-Ariel
Copy link
Contributor Author

@udi-speedb rebased on main with zlib fix.

udi-speedb
udi-speedb previously approved these changes Jan 28, 2024
@Yuval-Ariel Yuval-Ariel merged commit 536f779 into main Jan 29, 2024
17 of 19 checks passed
@Yuval-Ariel Yuval-Ariel deleted the yuval/disable-tracing-with-use-txn branch January 29, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants