Bugfixes and additional APIs required for Goofyscache compatibility with goofys v0.24 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 16, 2020 19:04
bensussman
changed the title
added 9 commits
September 28, 2020 18:38
…ger.Downloader for S3 backends, and fall back to storageBackend.GetBlob() in other cases
jayschwa
reviewed
Oct 6, 2020
internal/goofys.go
Outdated
| // Get the continuation token from the prior result. | ||
| ContinuationToken: res.NextContinuationToken, | ||
| } | ||
| res, err := fs.storageBackend.ListBlobs(listBlobsInput) |
There was a problem hiding this comment.
Has this been tested? My intuition is that this is a new res that will shadow the original and not actually affect the loop condition.
libeks
approved these changes
Oct 7, 2020
bensussman
force-pushed
the
expose-internal-cloud-provider
branch
from
8538933
to
ea4af91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to house the changes goofyscache needs to work with S3 with the updated v0.24 of goofys
(NOTE: Azure support will come later)