Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.shell impl #30

Merged
merged 12 commits into from
Jun 22, 2022
Merged

sys.shell impl #30

merged 12 commits into from
Jun 22, 2022

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Mar 19, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@hulto hulto marked this pull request as draft April 2, 2022 16:02
@hulto hulto marked this pull request as ready for review April 2, 2022 16:32
Milkshak3s
Milkshak3s approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@Milkshak3s Milkshak3s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

implants/eldritch/src/sys/shell_impl.rs Show resolved Hide resolved
@hulto hulto merged commit e7fdb73 into main Jun 22, 2022
@hulto hulto deleted the hulto-eldritch-feature-sys-shell branch June 22, 2022 00:26
KCarretto pushed a commit that referenced this pull request Feb 1, 2024
@hulto
72927f8 
 
sys.shell impl, doc, test (#30)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milkshak3s Milkshak3s Milkshak3s approved these changes

@Cictrone Cictrone Awaiting requested review from Cictrone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hulto @Milkshak3s