-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] gRPC #380
[feature] gRPC #380
Conversation
implants/lib/c2/Cargo.toml
Outdated
tokio = { version = "1.0", features = ["macros", "rt-multi-thread"] } | ||
|
||
[build-dependencies] | ||
tonic-build = "0.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to the parent workspace.
If other parts of realm use it in the future would be nice to continue our standard of using one version of a dep across the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk how to add build dependencies there, no existing section for them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be able to add:
[workspace.build-dependencies]
tonic-build = "0.10"
to between dependencies and profile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't work like that, would require us to add it to the workspace dependencies:
Caused by:
failed to load manifest for dependency `c2`
Caused by:
failed to parse manifest at `/workspaces/realm/implants/lib/c2/Cargo.toml`
Caused by:
error inheriting `tonic-build` from workspace root manifest's `workspace.dependencies.tonic-build`
Caused by:
`dependency.tonic-build` was not found in `workspace.dependencies`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added them to the workspace dependencies I guess /shrug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #380 +/- ##
==========================================
- Coverage 75.35% 68.49% -6.87%
==========================================
Files 107 106 -1
Lines 7255 7122 -133
==========================================
- Hits 5467 4878 -589
- Misses 1690 2136 +446
- Partials 98 108 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second look over couple more comments.
[feature] gRPC (#380) * refactoring endpoints * refactor http setup * Updated release.sh to set Tavern version * began implementing server * some more implementation * fix issues, add testing * Working on rust client * it might work ¯\_(ツ)_/¯ * it works, but im not happy about it * some cleanup, fix agent crash if no connection available * attempt to fix some codegen * log warning if protos aren't compiled * Fix build.rs * enable http2 * Use name as task.id * disable debug mode for imix: * rm dead code * remove dead code, update which version * Add some gRPC docs * move build dependencies to workspace dependencies
What type of PR is this?
/kind feature
What this PR does / why we need it:
Changes:
What’s left:
Which issue(s) this PR fixes:
Fixes #331