Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netmask to get ip #659

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Add netmask to get ip #659

merged 7 commits into from
Feb 24, 2024

Conversation

hulto
Copy link
Collaborator

@hulto hulto commented Feb 24, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

Add netmask CIDR to sys.get_ip
Remove get_ip dependency on pnet crate.

Which issue(s) this PR fixes:

Unblocks #484

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 72.02%. Comparing base (80eea9c) to head (2e3476b).

Files Patch % Lines
implants/lib/eldritch/src/sys/get_ip_impl.rs 80.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #659      +/-   ##
==========================================
- Coverage   72.08%   72.02%   -0.06%     
==========================================
  Files         175      175              
  Lines       12018    12008      -10     
==========================================
- Hits         8663     8649      -14     
- Misses       3141     3145       +4     
  Partials      214      214              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cictrone
Cictrone previously approved these changes Feb 24, 2024
Copy link
Collaborator

@Cictrone Cictrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small typo, otherwise lgtm!

@hulto hulto merged commit 2e96df1 into main Feb 24, 2024
5 of 6 checks passed
@hulto hulto deleted the add-netmask-to-get-ip branch February 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants