Compatibility for NOAA and IRIDL data sets #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks really good @jdossgollin; I just have one minor suggestion regarding the formatting of the what's new entry.
spencerkclark
approved these changes
Nov 12, 2018
|
Thanks much @jdossgollin ! Congrats on your first aospy PR, and sorry again for those aspects of the procedure that we accidentally made pretty confusing. |
|
Thanks for the patience and guidance @spencerahill and @spencerkclark ! |
|
No problem at all. Looking forward to additional future contributions from you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293 and #299.
This PR makes two changes which make aospy compatible with a greater range of data sets, specifically including those from the IRI Data Library and NOAA data sets such as the NCEP-NCAR Reanalysis. This compatibility is expanded through (1) the addition of several new names for
GRID_ATTRSas discussed in #293 (forX,Y,P, and #299 (fornbnds);landwas not discussed in a previous issue but is also a relevant use case without likelihood of confusion, and (2) a modification ofensure_time_avg_has_cf_metadatato avoid the assumption thatBOUNDS_STRis a coordinate oftime_weightsas discussed in #299.