Add a Linux/AppImage build #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like a problem that didn't surface under Windows or macOS, which typically use case-insensitive file systems, as opposed to Linux, where case-sensitive file systems are more common.
fwcd
commented
Apr 8, 2024
| @@ -2,7 +2,7 @@ import React from 'react' | |||
| import styled from 'styled-components' | |||
| import zIndexes from '../zIndexes' | |||
| import UniverseIcon from '@mui/icons-material/Settings' | |||
| import LightingIcon from '@mui/icons-material/LightBulb' | |||
| import LightingIcon from '@mui/icons-material/Lightbulb' | |||
There was a problem hiding this comment.
A minor issue that surfaced during the build were a few miscapitalized imports, which presumably weren't a problem on macOS and Windows where file systems are usually case-insensitive (as opposed to Linux).
|
Looks pretty chill. I can't imagine how this could negatively affect existing windows or mac builds. I don't have capacity to test linux builds myself, but there's no reason not to give interested people a leg up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35
This adds an experimental Linux build along with a corresponding Ubuntu CI configuration. The
package.jsonalready includes an electron-builder configuration producing an AppImage on Linux, so the changes required to the code are minimal.