-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove useless enforced dependency of PyUSB #1091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyUSB will be automatically used if present.
ecdsa
pushed a commit
that referenced
this pull request
Mar 19, 2015
Remove useless enforced dependency of PyUSB
protonn
pushed a commit
to argentumproject/electrum-arg
that referenced
this pull request
Feb 15, 2019
* Fix FloatingActionButton positioning on API levels before 21 * Use pkgutil to load data files, so `electroncash` package doesn't need to be extracted on Android: Closes spesmilo#1062, which I assume was caused by the cache directory being cleared while the app was running. * Update to Chaquopy 5.0.7 (closes spesmilo#1060) * Use new Chaquopy primitive conversion methods * Use new Chaquopy container view methods * Update to Chaquopy 5.1.0 / Pin version of pycryptodomex * Use correct container interface when calling get_blockchains * Add missing lock (closes spesmilo#1109) * Don't restore UI state if process has been restarted (closes spesmilo#1057, closes spesmilo#1093, closes spesmilo#1095) * Fix "Can not perform this action after onSaveInstanceState" errors (closes spesmilo#1083, closes spesmilo#1091, closes spesmilo#1103) * Trigger onShowDialog from DialogFragment.onStart rather than Dialog.setOnShowListener (closes spesmilo#1108, and see also spesmilo#1046) * Don't show temporary files in wallet list (closes spesmilo#1102) * ImageView size is now unavailable in onShowDialog, so get QR resolution from resource instead * Catch network exceptions at top level of Connection thread (closes spesmilo#1096) * Add missing locks * Fix unit tests * Update Android license agreement hash
Toporin
pushed a commit
to Toporin/electrum-satochip
that referenced
this pull request
Sep 25, 2019
* Update Chaquopy pycryptodomex hashes * Add Romanian plural formula * Take default cashaddr format setting from back end * Simplify main activity fragment tracking (closes spesmilo#1576) * Add another null check for TextView.getLayout (closes spesmilo#1592) * Fix intent handler so URIs are never processed multiple times * Factor out base class for all dialogs which work on a background thread, and ensure multiple threads are never created (closes spesmilo#1575) * Add uncapitalized string * Migrate to AndroidX using IDE * Tidy up after migration * Move `py` variable from Daemon.kt to App.kt: On startup, if ACRA attempts to resend a crash report which previously failed, it accesses `py` to get the Python version number. But this also initializes all the other global variables in the same file, which caused the following exception: java.lang.IllegalStateException: Cannot invoke setValue on a background thread at androidx.lifecycle.LiveData.assertMainThread(LiveData.java:443) at androidx.lifecycle.LiveData.setValue(LiveData.java:286) at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33) at org.electroncash.electroncash3.DaemonKt.<clinit>(Daemon.kt:23) at org.electroncash.electroncash3.DaemonKt.getPy(Unknown Source:0) at org.electroncash.electroncash3.CrashKt$reportToJson$4.invoke(Crash.kt:102) at org.electroncash.electroncash3.CrashKt$reportToJson$4.invoke(Unknown Source:0) at org.electroncash.electroncash3.CrashKt.putJson(Crash.kt:116) at org.electroncash.electroncash3.CrashKt.reportToJson(Crash.kt:101) at org.electroncash.electroncash3.CrashhubSender.convertToString(Crash.kt:62) at org.acra.sender.HttpSender.send(HttpSender.java:127) at org.acra.sender.ReportDistributor.sendCrashReport(ReportDistributor.java:111) at org.acra.sender.ReportDistributor.distribute(ReportDistributor.java:76) at org.acra.sender.SenderService.onHandleWork(SenderService.java:84) at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:392) at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:383) at android.os.AsyncTask$2.call(AsyncTask.java:333) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:764) * Fix Enter key repeating if ACTION_UP is lost during a rotation * Update to androidx.fragment and androidx.appcompat version 1.1.0 (closes spesmilo#1091) * Implement AlertDialogFragment.createView (spesmilo#1091) * Access synthetic properties on fragment rather than dialog / Remove dialog parameter from onShowDialog and onFirstShowDialog * Work around toast bug in Android 7.1 (closes spesmilo#1528) * Fix warning
Toporin
pushed a commit
to Toporin/electrum-satochip
that referenced
this pull request
Feb 16, 2021
* Fix FloatingActionButton positioning on API levels before 21 * Use pkgutil to load data files, so `electroncash` package doesn't need to be extracted on Android: Closes spesmilo#1062, which I assume was caused by the cache directory being cleared while the app was running. * Update to Chaquopy 5.0.7 (closes spesmilo#1060) * Use new Chaquopy primitive conversion methods * Use new Chaquopy container view methods * Update to Chaquopy 5.1.0 / Pin version of pycryptodomex * Use correct container interface when calling get_blockchains * Add missing lock (closes spesmilo#1109) * Don't restore UI state if process has been restarted (closes spesmilo#1057, closes spesmilo#1093, closes spesmilo#1095) * Fix "Can not perform this action after onSaveInstanceState" errors (closes spesmilo#1083, closes spesmilo#1091, closes spesmilo#1103) * Trigger onShowDialog from DialogFragment.onStart rather than Dialog.setOnShowListener (closes spesmilo#1108, and see also spesmilo#1046) * Don't show temporary files in wallet list (closes spesmilo#1102) * ImageView size is now unavailable in onShowDialog, so get QR resolution from resource instead * Catch network exceptions at top level of Connection thread (closes spesmilo#1096) * Add missing locks * Fix unit tests * Update Android license agreement hash
Toporin
pushed a commit
to Toporin/electrum-satochip
that referenced
this pull request
Feb 16, 2021
* Update Chaquopy pycryptodomex hashes * Add Romanian plural formula * Take default cashaddr format setting from back end * Simplify main activity fragment tracking (closes spesmilo#1576) * Add another null check for TextView.getLayout (closes spesmilo#1592) * Fix intent handler so URIs are never processed multiple times * Factor out base class for all dialogs which work on a background thread, and ensure multiple threads are never created (closes spesmilo#1575) * Add uncapitalized string * Migrate to AndroidX using IDE * Tidy up after migration * Move `py` variable from Daemon.kt to App.kt: On startup, if ACRA attempts to resend a crash report which previously failed, it accesses `py` to get the Python version number. But this also initializes all the other global variables in the same file, which caused the following exception: java.lang.IllegalStateException: Cannot invoke setValue on a background thread at androidx.lifecycle.LiveData.assertMainThread(LiveData.java:443) at androidx.lifecycle.LiveData.setValue(LiveData.java:286) at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:33) at org.electroncash.electroncash3.DaemonKt.<clinit>(Daemon.kt:23) at org.electroncash.electroncash3.DaemonKt.getPy(Unknown Source:0) at org.electroncash.electroncash3.CrashKt$reportToJson$4.invoke(Crash.kt:102) at org.electroncash.electroncash3.CrashKt$reportToJson$4.invoke(Unknown Source:0) at org.electroncash.electroncash3.CrashKt.putJson(Crash.kt:116) at org.electroncash.electroncash3.CrashKt.reportToJson(Crash.kt:101) at org.electroncash.electroncash3.CrashhubSender.convertToString(Crash.kt:62) at org.acra.sender.HttpSender.send(HttpSender.java:127) at org.acra.sender.ReportDistributor.sendCrashReport(ReportDistributor.java:111) at org.acra.sender.ReportDistributor.distribute(ReportDistributor.java:76) at org.acra.sender.SenderService.onHandleWork(SenderService.java:84) at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:392) at androidx.core.app.JobIntentService$CommandProcessor.doInBackground(JobIntentService.java:383) at android.os.AsyncTask$2.call(AsyncTask.java:333) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641) at java.lang.Thread.run(Thread.java:764) * Fix Enter key repeating if ACTION_UP is lost during a rotation * Update to androidx.fragment and androidx.appcompat version 1.1.0 (closes spesmilo#1091) * Implement AlertDialogFragment.createView (spesmilo#1091) * Access synthetic properties on fragment rather than dialog / Remove dialog parameter from onShowDialog and onFirstShowDialog * Work around toast bug in Android 7.1 (closes spesmilo#1528) * Fix warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyUSB will be automatically used if present.