Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to tip the server in a transaction #1062

Closed
wants to merge 3 commits into from

Conversation

henrikssn
Copy link

This adds a new field in preferences which tips the server on every transaction.

Default server fee is 0. Server address is parsed from the welcome banner. If parsing fails then no tip is added to the transaction.

See discussion on bitcointalk

@ecdsa
Copy link
Member

ecdsa commented Mar 8, 2015

  1. you don't need to parse the banner, there is already a 'server.donation_address' request in the protocol.
  2. this should be a plugin
  3. you should check how it interacts with other plugins that add a fee to the transaction (trustedcoin.py)
  4. it should not tip silently, tipping should be visible to the user.
  5. in order to save miner fees and avoid dust, better donate a larger amount every 10 transaction

@ecdsa ecdsa closed this May 23, 2015
protonn pushed a commit to argentumproject/electrum-arg that referenced this pull request Feb 15, 2019
* Fix FloatingActionButton positioning on API levels before 21

* Use pkgutil to load data files, so `electroncash` package doesn't need to be extracted on Android:
Closes spesmilo#1062, which I assume was caused by the cache directory being cleared while the app was running.

* Update to Chaquopy 5.0.7 (closes spesmilo#1060)

* Use new Chaquopy primitive conversion methods

* Use new Chaquopy container view methods

* Update to Chaquopy 5.1.0  /  Pin version of pycryptodomex

* Use correct container interface when calling get_blockchains

* Add missing lock (closes spesmilo#1109)

* Don't restore UI state if process has been restarted (closes spesmilo#1057, closes spesmilo#1093, closes spesmilo#1095)

* Fix "Can not perform this action after onSaveInstanceState" errors (closes spesmilo#1083, closes spesmilo#1091, closes spesmilo#1103)

* Trigger onShowDialog from DialogFragment.onStart rather than Dialog.setOnShowListener (closes spesmilo#1108, and see also spesmilo#1046)

* Don't show temporary files in wallet list (closes spesmilo#1102)

* ImageView size is now unavailable in onShowDialog, so get QR resolution from resource instead

* Catch network exceptions at top level of Connection thread (closes spesmilo#1096)

* Add missing locks

* Fix unit tests

* Update Android license agreement hash
Toporin pushed a commit to Toporin/electrum-satochip that referenced this pull request Feb 16, 2021
* Fix FloatingActionButton positioning on API levels before 21

* Use pkgutil to load data files, so `electroncash` package doesn't need to be extracted on Android:
Closes spesmilo#1062, which I assume was caused by the cache directory being cleared while the app was running.

* Update to Chaquopy 5.0.7 (closes spesmilo#1060)

* Use new Chaquopy primitive conversion methods

* Use new Chaquopy container view methods

* Update to Chaquopy 5.1.0  /  Pin version of pycryptodomex

* Use correct container interface when calling get_blockchains

* Add missing lock (closes spesmilo#1109)

* Don't restore UI state if process has been restarted (closes spesmilo#1057, closes spesmilo#1093, closes spesmilo#1095)

* Fix "Can not perform this action after onSaveInstanceState" errors (closes spesmilo#1083, closes spesmilo#1091, closes spesmilo#1103)

* Trigger onShowDialog from DialogFragment.onStart rather than Dialog.setOnShowListener (closes spesmilo#1108, and see also spesmilo#1046)

* Don't show temporary files in wallet list (closes spesmilo#1102)

* ImageView size is now unavailable in onShowDialog, so get QR resolution from resource instead

* Catch network exceptions at top level of Connection thread (closes spesmilo#1096)

* Add missing locks

* Fix unit tests

* Update Android license agreement hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants