sendmany attempt #187
Merged
sendmany attempt #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A simple argument parsing change from mktx to allow passing multiple recipients
Just like mktx/payto, this is only submitting the tx created in mksendmanytx
ghost
assigned 
|
Will this be merged? Would love to have sendmany on Electrum also. |
ecdsa
pushed a commit
that referenced
this pull request
Aug 17, 2013
merging sendmany attempt in master
|
merged to 1.9 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to have sendmany like in bitcoin-qt, but with change address and fee control. Of course electrum is always my go-to client for custom tailored transactions without the perils of creating them by hand, so I took a stab at it.
I have not tested actually submitting the tx, but I reviewed a bunch of them from mksendmanytx and it looks very sane, as it should as the change is minimal.
I thought about piggybacking on payto/mktx, as the optional 'label' described in the help text does not seem to be processed anywhere, but I only did a quick search for it and didn't want to change the existing command expected behaviour.