windows build: for the "setup" exe, put another "-debug" exe inside #6603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "setup" Windows binary we distribute allows users to "install" Electrum on their system. The distributable is created by NSIS. During installation a bunch of files will get unpacked in %programfiles(x86)%/Electrum, including an "inner" exe that will be the entrypoint for the user to start the application. A shortcut is also created for the inner exe. With this change, there will now be two inner EXEs. One the same as before, the other with a "-debug" suffix in its name. The debug exe is built as a "console" application (as opposed to a "windowed" application), so when launched via double-click a black console window would appear; and also importantly stdin/stdout are handled properly for it (unlike for "windowed" programs). (see spesmilo#2592) There will not be a shortcut or similar for the debug exe; it would just be there as a debugging option we can instruct users to use when needed. In particular early crashes during startup are hard to debug without stdout/stderr. (see e.g. spesmilo#6601)
reddink
pushed a commit
to reddcoin-project/electrum-redd
that referenced
this pull request
Nov 10, 2020
…pesmilo#6603) The "setup" Windows binary we distribute allows users to "install" Electrum on their system. The distributable is created by NSIS. During installation a bunch of files will get unpacked in %programfiles(x86)%/Electrum, including an "inner" exe that will be the entrypoint for the user to start the application. A shortcut is also created for the inner exe. With this change, there will now be two inner EXEs. One the same as before, the other with a "-debug" suffix in its name. The debug exe is built as a "console" application (as opposed to a "windowed" application), so when launched via double-click a black console window would appear; and also importantly stdin/stdout are handled properly for it (unlike for "windowed" programs). (see spesmilo#2592) There will not be a shortcut or similar for the debug exe; it would just be there as a debugging option we can instruct users to use when needed. In particular early crashes during startup are hard to debug without stdout/stderr. (see e.g. spesmilo#6601) (cherry picked from commit 653a24a) # Conflicts: # contrib/deterministic-build/electrum-redd-locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "setup" Windows binary we distribute allows users to "install" Electrum
on their system. The distributable is created by NSIS. During
installation a bunch of files will get unpacked in %programfiles(x86)%/Electrum,
including an "inner" exe that will be the entrypoint for the user to start
the application. A shortcut is also created for the inner exe.
With this change, there will now be two inner EXEs. One the same as before,
the other with a "-debug" suffix in its name. The debug exe is built as a
"console" application (as opposed to a "windowed" application), so when
launched via double-click a black console window would appear; and also
importantly stdin/stdout are handled properly for it (unlike for "windowed"
programs). (see #2592)
There will not be a shortcut or similar for the debug exe; it would just
be there as a debugging option we can instruct users to use when needed.
In particular early crashes during startup are hard to debug without
stdout/stderr. (see e.g. #6601)