Bip38 import #816
Closed
Bip38 import #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added bip38 decryption, tests, and sweep function
Conflicts: setup.py Update bip38 to use slowaes instead of a second aes implementation
|
travis fails because decr is not assigned in bitcoin.py line 83. |
|
The reason I didn't do the same sweep menu is that if there are multiple private keys, the password dialog could get confusing. It would need to ask for the password to each key individually. I can change it around to do that instead of a separate menu option. |
…p38_import Conflicts: .travis.yml gui/qt/main_window.py setup.py
|
My vote for this pull request. |
|
please resubmit as a plugin; this feature requires non-python dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bip38 import capability