Add support for Satochip hardware wallet #8453

Toporin · 2023-05-24T19:40:47Z

This is a pull request to add support for the Satochip hardware wallet.

The Satochip hardware wallet is based on a jacavard smartcard and is fully open-source.
The wallet is composed of a javacard applet that is to be loaded on the smartcard, and an Electrum client plugin that acts as the interface between the card and the network. An optional 2FA setting allows to confirm transaction requests on a second android device before signing them (iOS version coming soon).

This pull request updates and supersedes #7690, #7518 and #6520.

Changes compared to previous PR:
*Based on latest release Electrum v4.4.3
*Use pysatochip v0.12.3
*Suport for Satochip applet up to v0.12 (instead of v0.11)

New functionalities in Satochip applet v0.12:
*Card authenticity verification based on device certificate & PKI
*Reset to factory option (e.g. if user forget his PIN code or 2FA device)
*Support for importing encrypted seed from a SeedKeeper

More info:
https://github.com/Toporin/ (official repository)
https://pypi.org/project/pysatochip/ (pysatochip library)
https://prezi.com/p/mpq-xhh3mxjl/satochip-gent-meetup/ (Slides from previous meetups in Belgium)
https://t.me/Satochip (Telegram support)

Basic Satochip plugin functionnal No SegWit support yet

- parse segwit tx - sign tx Electrum-Satochip integration: - store authentikey in (encrypted) storage - Device setup: prompt for PIN & Seed

Check Satochip version for support via card_get_status()

* Refactor card_bip32_import_seed() and card_bip32_get_authentikey(): return authentikey instead of (response, sw1, sw2) * New class UninitializedSeedError(Exception) thrown when device has no seed

…e) directly remove debug comments and clean code a bit

… and card insertion/removal

# Conflicts: # contrib/build-osx/make_osx # contrib/build-osx/osx.spec # contrib/build-osx/package.sh # contrib/build-wine/build-electrum-git.sh # contrib/build-wine/build-secp256k1.sh # contrib/build-wine/build.sh # contrib/build-wine/deterministic.spec # contrib/build-wine/prepare-wine.sh # contrib/build-wine/sign.sh # contrib/build-wine/unsign.sh # contrib/deterministic-build/check_submodules.sh # contrib/deterministic-build/find_restricted_dependencies.py # contrib/freeze_packages.sh # contrib/make_apk # contrib/make_download # contrib/make_locale # contrib/make_packages # contrib/make_tgz # contrib/sign_packages # contrib/upload # electrum # electrum-env # gui/kivy/data/fonts/tron/License.txt # gui/kivy/data/fonts/tron/Readme.txt # lib/base_wizard.py # lib/crypto.py # lib/plugins.py # lib/ripemd.py # lib/wordlist/portuguese.txt # plugins/trezor/trezor.py # scripts/bip70 # scripts/block_headers # scripts/estimate_fee # scripts/get_history # scripts/peers # scripts/servers # scripts/txradar # scripts/watch_address # setup.py Signed-off-by: Baudoin <bcollard@gmail.com>

various code cleaning, set random PIN for unused pin/puk code

* card_get_status() returns number of pin/puk tries remaining * PIN verification is refactored in card_verify_PIN()

Merge commit '87c596fa1d685b9365c26b9dfabe9c566f806ea0' into satochip # Conflicts: # .gitignore # README.rst # contrib/build-linux/appimage/apprun.sh # contrib/build-linux/appimage/build.sh # contrib/build-osx/osx.spec # contrib/build-wine/build-electrum-git.sh # contrib/build-wine/deterministic.spec # contrib/build-wine/prepare-wine.sh # contrib/build_tools_util.sh # contrib/osx/make_osx # contrib/sign_version # electrum/base_wizard.py # electrum/plugin.py # icons.qrc # lib/crypto.py

In CardConnector.py: - Encrypt/decrypt 2FA challenge/response for privacy - erase PIN when card is removed In Satochip.py: - pairing with 2FA device using QR code - if 2FA is enabled, tx signing requires response to challenge using hmac-sha1 New plugin in satochip_2FA folder: exchange challenge-response with 2FA device Minor changes in TxParser.py, plugin.py

Merge remote-tracking branch 'upstream/master' into satochip # Conflicts: # .gitignore # README.rst # contrib/build-wine/build-electrum-git.sh # contrib/build-wine/prepare-wine.sh # electrum/base_wizard.py # electrum/plugin.py

- contrib/build-wine/LICENCE - contrib/build-wine/tmp/electrum/ - contrib/osx/package.sh~HEAD

- removed README-electrum.rst - undo changes to README.rst - removed debug traces in contrib/build-wine/deterministic.spec - add pyscard in contrib/requirements/requirements-hw.txt

Merge branch 'Electrum-Satochip-v3.3.8-0.7' into satochip: - removed README-electrum.rst - undo changes to README.rst - removed debug traces in contrib/build-wine/deterministic.spec - add pyscard in contrib/requirements/requirements-hw.txt

Support for Satochip v0.8 (improved 2-Factor-Authentication support): * A new setting menu is available when clicking on the satochip logo in the low right corner of the window. * Add support for PIN change and seed reset * In addition to transactions, 2FA is now required to sign messages, import eckey and reset seed/eckey/2FA. * 2FA can be disabled, only when the seed and all private keys are cleared. Added support for Satochip in AppImage. To run the AppImage on Linux: $ chmod a+x electrum*.AppImage $ ./electrum*.AppImage

Support for Satochip v0.8 (improved 2-Factor-Authentication support): * A new setting menu is available when clicking on the satochip logo in the low right corner of the window. * Add support for PIN change and seed reset * In addition to transactions, 2FA is now required to sign messages, import eckey and reset seed/eckey/2FA. * 2FA can be disabled, only when the seed and all private keys are cleared. Added support for Satochip in AppImage. To run the AppImage on Linux: $ chmod a+x electrum*.AppImage $ ./electrum*.AppImage Merge branch 'electrum-satochip-v3.3.8-0.8' into satochip

Only BIP39 seedd import (from existing seed) is currently supported.

Changes in pysatochip: drop pyaes and pyopenssl dependencies

SomberNight · 2023-06-22T14:20:57Z

contrib/osx/make_osx.sh

+brew install autoconf automake libtool gettext coreutils pkgconfig
+
+
+info "Building PyInstaller."


this whole block is duplicated from above?
see line 123

Yes, sorry, the MacOS build is still a work in progress, I pushed the changes I made so far to the Satochip repo in order to work on the mac build from my mac...

If this PR is still in progress better to change it into a draft

Toporin · 2023-06-23T08:47:27Z

The PR is ready for review.

Latest changes:

upgraded pysatochip to v0.12.5, removing pyopenssl and pyaes dependencies
on Satochip wallet setup, if the wallet is not seeded, allows to import an existing BIP39 seed, but not generating a new one from Electrum
Simplify MacOS build (only swig is needed to build pyscard from sources)
Added a 'cancel' option to QRDialog init method, the default behavior is unchanged.

Note that I have not been able to build the windows build yet due to #8496

gruve-p · 2023-06-23T10:54:13Z

Note that I have not been able to build the windows build yet due to #8496

You can turn off the snapshot archive (comment these 2 lines for windows: https://github.com/spesmilo/electrum/blob/master/contrib/build-wine/Dockerfile#L8-L9)

SomberNight · 2023-06-23T12:26:56Z

contrib/osx/make_osx.sh

@@ -256,4 +255,4 @@ DoCodeSignMaybe ".DMG" "dist/electrum-${VERSION}.dmg"
 if [ -z "$CODESIGN_CERT" ]; then
    warn "App was built successfully but was not code signed. Users may get security warnings from macOS."
    warn "Specify a valid code signing identity to enable code signing."
-fi
+fi


please fix the code formatting issues so that the flake8 tests pass
https://cirrus-ci.com/task/4585331354238976

for example, "no newline at end of file"

Download the binary wheel from Satochip repo and install it. We use a slightly modified version of 'requirements-hw' with pyscard package removed, otherwise pip install fails since no wheels are supported for windows.

For windows build, use pyscard binary wheels for win32.

Aucun périphérique matériel détecté. Pour déclencher un nouveau scan, pressez 'Suivant'. Sur Linux, vous pouvez avoir à ajouter une nouvelle permission à vos règles udev. Message de débogage bitbox02: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading bitbox02 plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") coldcard: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading coldcard plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") digitalbitbox: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading digitalbitbox plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") jade: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading jade plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") keepkey: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading keepkey plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") ledger: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading ledger plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") safe_t: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading safe_t plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") satochip: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading satochip plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)") trezor: (error during plugin init) Vous avez peut-être une bibliothèque incompatible. Error loading trezor plugin: ImportError("cannot import name 'parse_URI' from 'electrum.util' (/Users/satochip/Documents/github/electrum-satochip/dist/Electrum.app/Contents/MacOS/electrum/util.pyc)")

Toporin · 2023-07-10T13:31:47Z

This PR is now ready for review!

Main changes:

upgraded pysatochip to v0.12.5, removing pyopenssl and pyaes dependencies
upgraded pyscard to latest version v2.0.7, using binary wheels for Windows only
on Satochip wallet setup, if the wallet is not seeded, allows to import an existing BIP39 seed, but not generating a new one from Electrum
Simplify MacOS build (only swig is needed to build pyscard from sources)
Added a 'cancel' option to QRDialog init method, the default behavior is unchanged.
Fix code format using Flake8 and Autopep8

gruve-p · 2023-09-20T18:17:15Z

contrib/deterministic-build/requirements-hw.txt

@@ -220,6 +220,22 @@ pyaes==1.6.1 \
 pycparser==2.21 \
    --hash=sha256:8ee45429555515e1f6b185e78100aea234072576aa43ab53aefcae078162fca9 \
    --hash=sha256:e644fdec12f7872f86c58ff790da456218b10f863970249516d60a5eaca77206
+pysatochip==0.12.5 \


Why is 0.14.1 and 0.14.2 marked as latest on pypi (but has a date of 2021)? That confused me.

gruve-p · 2023-09-20T18:22:51Z

electrum/plugins/satochip/README.rst

+Satochip plugin for electrum
+=================================================================================
+
+::
+
+  Licence: MIT Licence
+  Author: Toporin
+  Language: Python (>= 3.6)
+  Homepage: https://github.com/Toporin/electrum-satochip
+
+Introduction
+============
+
+This plugin allows to integrate the Satochip Hardware Wallet with Electrum. To use it, you need a device with the Satochip javacard applet installed (see https://github.com/Toporin/SatochipApplet).
+If the wallet is not intialized yet, Electrum will perform the setup (you only need to do this once). During setup, a seed is created: this seed allows you to recover your wallet at anytime, so make sure to BACKUP THE SEED SECURELY! During setup, a PIN code is also created: this PIN allows to unlock th device to access your funds. If you try too many wrong PIN, your device will be locked indefinitely (it is 'bricked'). If you loose your PIN or brick your device, you can only recover your funds with the seed backup.
+
+The Satochip wallet is currently in Beta, use with caution!You can use the software on the Bitcoin testnet using the --testnet option.
+This software is provided 'as-is', without any express or implied warranty. In no event will the authors be held liable for any damages arising from the use of this software.
+
+Rem: Electrum uses Python 3.x. In case of error, check first that you are not trying to run Electrum with Python 2.x or with Python 2.x libraries.
+
+Development version (Windows 64bits)
+=====================================
+
+Install the latest python 3.6 release from https://www.python.org (https://www.python.org/downloads/release/python-368/)
+(Caution: installing another release than 3.6 may cause incompatibility issues with pyscard)
+
+Clone or download the code from GitHub.
+
+Open a PowerShell command line in the electrum folder
+
+In PowerShell, install the electrum dependencies::
+
+    python -m pip install .   
+
+You may also ned to install Python3-pyqt5::
+
+    python -m pip install pyqt5
+
+Install pyscard from https://pyscard.sourceforge.io/
+Pyscard is required to connect to the smartcard::
+
+    python -m pip install pyscard
+
+
+In PowerShell, run electrum on the testnet (-v allows for verbose output)::
+
+    python .\run_electrum -v --testnet
+
+
+Development version (Ubuntu)
+==============================
+(Electrum requires Python 3.6, which should be installed by default on Ubuntu)
+(If necessary, install pip: sudo apt-get install python3-pip)
+
+Electrum is a pure python application. To use the
+Qt interface, install the Qt dependencies::
+
+    sudo apt-get install python3-pyqt5
+
+Check out the code from GitHub::
+
+    git clone git://github.com/Toporin/electrum.git
+    cd electrum
+
+In the electrum folder:    
+
+Run install (this should install dependencies)::
+
+    python3 -m pip install .
+
+Install pyscard (https://pyscard.sourceforge.io/)
+Pyscard is required to connect to the smartcard:: 
+    sudo apt-get install pcscd
+    sudo apt-get install python3-pyscard
+(For alternatives, see https://github.com/LudovicRousseau/pyscard/blob/master/INSTALL.md for more detailed installation instructions)
+
+
+To run Electrum use::
+ python3 electrum -v --testnet 
+
+
+


Not sure why this README is included? I do not see other hardware plugins having such a README.

gruve-p · 2023-09-20T18:26:29Z

electrum/plugins/satochip/satochip.py

+    # def choose_seed_legacy(self, wizard):
+    #     title = _('Create or restore')
+    #     message = _('Do you want to create a new seed, or to restore a wallet using an existing seed?')
+    #     choices = [
+    #         #('create_seed', _('Create a new BIP39 seed')),
+    #         ('restore_from_seed', _('I already have a BIP39 seed')),
+    #     ]
+    #     wizard.choice_dialog(title=title, message=message, choices=choices, run_next=wizard.run)
+
+    # #create seed
+    # def create_seed(self, wizard):
+    #     wizard.seed_type = 'bip39'
+    #     wizard.opt_bip39 = True
+    #     wizard.opt_slip39 = False
+    #     #seed = mnemonic.Mnemonic('en').make_seed(wizard.seed_type) # Electrum seed
+    #     seed= self.to_bip39_mnemonic(128)
+    #     f = lambda x: self.request_passphrase(wizard, seed, x)
+    #     wizard.show_seed_dialog(run_next=f, seed_text=seed)
+
+    # def request_passphrase(self, wizard, seed, opt_passphrase):
+    #     if opt_passphrase:
+    #         f = lambda x: self.confirm_seed(wizard, seed, x)
+    #         wizard.passphrase_dialog(run_next=f)
+    #     else:
+    #         wizard.run('confirm_seed', seed, '')
+
+    # def confirm_seed(self, wizard, seed, passphrase):
+    #     f = lambda x: self.confirm_passphrase(wizard, seed, passphrase)
+    #     wizard.confirm_seed_dialog(run_next=f, seed='', test=lambda x: x==seed)
+
+    # def confirm_passphrase(self, wizard, seed, passphrase):
+    #     f = lambda x: self.derive_bip39_seed(seed, x) #f = lambda x: self.derive_bip32_seed(seed, x)
+    #     if passphrase:
+    #         title = _('Confirm Seed Extension')
+    #         message = '\n'.join([
+    #             _('Your seed extension must be saved together with your seed.'),
+    #             _('Please type it here.'),
+    #         ])
+    #         wizard.line_dialog(run_next=f, title=title, message=message, default='', test=lambda x: x==passphrase)
+    #     else:
+    #         f('')


Do we need to keep this in?

gruve-p · 2023-09-20T18:26:45Z

electrum/plugins/satochip/satochip.py

+    # # based on https://github.com/trezor/python-mnemonic/blob/master/mnemonic/mnemonic.py
+    # def to_bip39_mnemonic(self, strength: int) -> str:
+    #     wordlist = mnemonic.Wordlist.from_file("english.txt")
+    #     data= urandom(strength // 8)
+    #     if len(data) not in [16, 20, 24, 28, 32]:
+    #         raise ValueError(
+    #             "Data length should be one of the following: [16, 20, 24, 28, 32], but it is not (%d)."
+    #             % len(data)
+    #         )
+    #     h = hashlib.sha256(data).hexdigest()
+    #     b = (
+    #         bin(int.from_bytes(data, byteorder="big"))[2:].zfill(len(data) * 8)
+    #         + bin(int(h, 16))[2:].zfill(256)[: len(data) * 8 // 32]
+    #     )
+    #     result = []
+    #     for i in range(len(b) // 11):
+    #         idx = int(b[i * 11 : (i + 1) * 11], 2)
+    #         result.append(wordlist[idx])
+    #     result_phrase = " ".join(result)
+    #     return result_phrase


Do we need to keep this in?

accumulator · 2023-09-21T12:16:41Z

Note: this PR still uses the old wizard integration. See #8560 for the new wizard branch. You can check other hardware wallets to get a sense of the changes involved. Let me know if you need some pointers.

Toporin · 2023-09-22T07:19:53Z

Thanks for the feedback @accumulator @gruve-p , I will update the PR accordingly!

Toporin · 2024-03-21T09:23:51Z

Superseded by new pull request: #8967

Alcofribas4 and others added 30 commits December 18, 2018 12:17

Initial commit

71e51de

Basic Satochip plugin functionnal No SegWit support yet

Basic Segwit support:

64191bd

- parse segwit tx - sign tx Electrum-Satochip integration: - store authentikey in (encrypted) storage - Device setup: prompt for PIN & Seed

Update support to Satochip v0.6 (non-hardened chilp optimization)

6668a05

Check Satochip version for support via card_get_status()

code cleaning: use card_transmit(apdu) instead of @unlock_pin wrapper

9a770c1

* Add Unit Tests for BIP32 derivation

707bb8c

* Refactor card_bip32_import_seed() and card_bip32_get_authentikey(): return authentikey instead of (response, sw1, sw2) * New class UninitializedSeedError(Exception) thrown when device has no seed

Add Unit Test: test card_sign_message()

3ea3e2b

refactor get_extended_key(): parse response and return (key, chaincod…

ecfff27

…e) directly remove debug comments and clean code a bit

Improved smartcard detection function 'detect_smartcard_reader(self)'…

dc70165

… and card insertion/removal

Remove old test class (replaced by test_CardConnector.py)

23ee3e8

update README,

1f2b83c

various code cleaning, set random PIN for unused pin/puk code

minor formatting

5789ad6

Change .gitignore to add ./gui/qt/icons_rc.py

a4e6ff5

add satochip icons in electrum

1017b1c

improve PIN support: prompt for PIN if needed

dc612ba

Improved PIN support:

591b297

* card_get_status() returns number of pin/puk tries remaining * PIN verification is refactored in card_verify_PIN()

packaging electrum-satochip into executable for windows

98a2321

Packaging electrum-satochip v3.3.4 into executable for windows

bb04379

cleanup & remove temporary build files for osx

5eeab49

Upgrade to Electrum-Satochip v3.3.8-0.7

23d857a

Merge remote-tracking branch 'upstream/master' into satochip # Conflicts: # .gitignore # README.rst # contrib/build-wine/build-electrum-git.sh # contrib/build-wine/prepare-wine.sh # electrum/base_wizard.py # electrum/plugin.py

Build .exe distributables with new pyscard .whl version (v.1.9.8)

75fb217

Update test suite in test_CardConnector.py

fdff14f

Remove temp files in contrib/build-wine

6676fad

- contrib/build-wine/LICENCE - contrib/build-wine/tmp/electrum/ - contrib/osx/package.sh~HEAD

Clean up code based on spesmilo#5523

1b949e7

Clean up code based on spesmilo#5523

bc44e6f

- removed README-electrum.rst - undo changes to README.rst - removed debug traces in contrib/build-wine/deterministic.spec - add pyscard in contrib/requirements/requirements-hw.txt

Clean up code based on spesmilo#5523

a3c351b

Merge branch 'Electrum-Satochip-v3.3.8-0.7' into satochip: - removed README-electrum.rst - undo changes to README.rst - removed debug traces in contrib/build-wine/deterministic.spec - add pyscard in contrib/requirements/requirements-hw.txt

Toporin added 4 commits June 21, 2023 07:51

Satochip setup wizard: remove BIP39 seed generation

116e5e1

Only BIP39 seedd import (from existing seed) is currently supported.

Upgrade pysatochip from v0.12.3 to 0.12.5

c540056

Changes in pysatochip: drop pyaes and pyopenssl dependencies

update locale

db5921c

Merge branch 'master' into electrum-satochip-v4.4.3-0.12

6f876f0

SomberNight reviewed Jun 22, 2023

View reviewed changes

Toporin marked this pull request as draft June 22, 2023 15:13

Add satochip support for MacOS build

331fe1f

Toporin marked this pull request as ready for review June 23, 2023 08:39

SomberNight reviewed Jun 23, 2023

View reviewed changes

Toporin marked this pull request as draft June 23, 2023 18:38

Toporin added 6 commits June 27, 2023 10:09

Workaround to build pyscard from win32 wheel (not available in pypi)

cd0cfe5

Download the binary wheel from Satochip repo and install it. We use a slightly modified version of 'requirements-hw' with pyscard package removed, otherwise pip install fails since no wheels are supported for windows.

Use autopep8 to correct flake8 errors

5a5605e

Bump pyscard to v2.0.7

59b4b5d

For windows build, use pyscard binary wheels for win32.

Merge branch 'master' into electrum-satochip-v4.4.3-0.12

b1467d2

Merge branch 'master' into electrum-satochip-v4.4.3-0.12

d95c687

Toporin marked this pull request as ready for review July 10, 2023 13:17

(minor) code formatting: add newline at end of file

1a143db

gruve-p reviewed Sep 20, 2023

View reviewed changes

Toporin mentioned this pull request Mar 21, 2024

Add support for Satochip hardware wallet #8967

Open

Toporin closed this Mar 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Satochip hardware wallet #8453

Add support for Satochip hardware wallet #8453

Toporin commented May 24, 2023

SomberNight Jun 22, 2023

Toporin Jun 22, 2023

gruve-p Jun 22, 2023

Toporin commented Jun 23, 2023

gruve-p commented Jun 23, 2023

SomberNight Jun 23, 2023

Toporin commented Jul 10, 2023

gruve-p Sep 20, 2023

gruve-p Sep 20, 2023

gruve-p Sep 20, 2023

gruve-p Sep 20, 2023

accumulator commented Sep 21, 2023

Toporin commented Sep 22, 2023

Toporin commented Mar 21, 2024

		brew install autoconf automake libtool gettext coreutils pkgconfig


		info "Building PyInstaller."

Add support for Satochip hardware wallet #8453

Add support for Satochip hardware wallet #8453

Conversation

Toporin commented May 24, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Toporin commented Jun 23, 2023

gruve-p commented Jun 23, 2023

Choose a reason for hiding this comment

Toporin commented Jul 10, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

accumulator commented Sep 21, 2023

Toporin commented Sep 22, 2023

Toporin commented Mar 21, 2024