Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed entrypoint python3 alias to accomodate Linux / Ubuntu installation #167

Closed
wants to merge 0 commits into from

Conversation

tbg-delegate
Copy link
Contributor

This removal should fix an error arising on Ubuntu / Linux, when spetlr is installed / uninstalled.

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Currently, deploying spetlr in a python Docker image yields an error with "too many levels of symbolic links" which usually implies that python3 symbol is misused.

The bug also implies that whenever spetlr is installed and subsequently uninstalled on Linux, python3/python disappears from the terminal, as the command python3 is removed with spetlr.

This PR may incur some unexpected development errors on Windows machines (according to @mrmasterplan), but we shall see :)

@LauJohansson
Copy link
Contributor

I will wait for the tests to succeed before reviewing

@tbg-delegate
Copy link
Contributor Author

tbg-delegate commented May 16, 2024

I will wait for the tests to succeed before reviewing

Check. @LauJohansson: I went on paternity leave on Monday, so will not be able to push this much further for now, which is quite annoying. Given that I only changed a really small thing, I honestly have no idea why the tests are failing.

The logs give several errors, but specifically this: pyspark.errors.exceptions.base.PySparkRuntimeError: [PYTHON_VERSION_MISMATCH] Python in worker has different version (3, 10) than that in driver 3.8, PySpark cannot run with different minor versions.

I believe activating a virtual environment inside the test workflow would be the proper way to handle this, but it's hard to know without spending a bit of time into the problem.

@tbg-delegate tbg-delegate requested review from mrmasterplan and removed request for mrmasterplan and LauJohansson September 3, 2024 08:07
@tbg-delegate
Copy link
Contributor Author

@mrmasterplan
Update on this, after my paternity leave: This is still a problem, and blocks using spetlr in my current project employment. I would like another deployment to parse through logs, and try out a few fixes.

@JeppeBlixen JeppeBlixen closed this Sep 6, 2024
@JeppeBlixen JeppeBlixen deleted the remove_python3_alias branch September 6, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants