Do not panic on passing empty tar reader to tarfs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects a bug where passing an empty tar reader to tarfs would cause adding the pseudoroot to panic with assignment to entry in nil map. Signed-off-by: hasheddan <georgedanielmangum@gmail.com>
|
|
6 tasks
|
Good catch! LGTM, thanks! |
0xmichalis
approved these changes
Oct 6, 2020
|
v1.4.1 is published |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects a bug where passing an empty tar reader to tarfs would cause
adding the pseudoroot to panic with assignment to entry in nil map.
Signed-off-by: hasheddan georgedanielmangum@gmail.com
cc @agimenez because it looked like you implemented tarfs (thank you for your work!)
@Kargakis would it be possible to get a v1.4.1 published after merge?