Parsing error for precompiled testing packages

[tonobo]

I have an binary which requires an external testing but i'm currently unable to do so with coverage tracking enabled. Please take a look at the following samples.

Creating test binary: go test -covermode=count -coverpkg ./... -o test-bin

Sample 1.

$ sudo ./test-bin -test.coverprofile=moo.cov pv allocation disable /dev/mapper/sda5_crypt
# Expected  => []string{"/dev/mapper/sda5_crypt"}
#      Got  => []string{}

Sample 2.

$ sudo ./test-bin pv allocation disable /dev/mapper/sda5_crypt
# Expected  => []string{"/dev/mapper/sda5_crypt"}
#      Got  => []string{"/dev/mapper/sda5_crypt"}

[shin-]

I'm currently having the same issue.

@tonobo Were you ever able to find a workaround?

[eparis]

This patch to github.com/spf13/pflag seems to make it work:

diff --git a/flag.go b/flag.go
index 5eadc84..31f2cbd 100644
--- a/flag.go
+++ b/flag.go
@@ -990,11 +990,11 @@ func (f *FlagSet) parseLongArg(s string, args []string, fn parseFunc) (a []strin
 }
 
 func (f *FlagSet) parseSingleShortArg(shorthands string, args []string, fn parseFunc) (outShorts string, outArgs []string, err error) {
+       outArgs = args
        if strings.HasPrefix(shorthands, "test.") {
                return
        }
 
-       outArgs = args
        outShorts = shorthands[1:]
        c := shorthands[0]
 

[shin-]

@eparis Thanks, that worked for me!