Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the commands store flagComp functions internally (and avoid global state) #2012

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Let the commands store flagComp functions internally (and avoid global state) #2012

wants to merge 12 commits into from

Commits on Aug 8, 2023

  1. Don't use global map for flag completions.

    @maxlandon
    maxlandon committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    f1f260e View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2023

  1. Ensure all completion maps are initialized before use

    @maxlandon
    maxlandon committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    53fb4eb View commit details
    Browse the repository at this point in the history

  2. Merge master, and adapt flag completion getters

    @maxlandon
    maxlandon committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    4d3a6e1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into completion

    @maxlandon
    maxlandon authored Sep 30, 2023
    Configuration menu
    Copy the full SHA
    d6df128 View commit details
    Browse the repository at this point in the history

  4. Avoid infinitely walking up the command tree

    @maxlandon
    maxlandon committed Sep 30, 2023
    Configuration menu
    Copy the full SHA
    5dad425 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'main' into completion

    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    13d042d View commit details
    Browse the repository at this point in the history

  2. Fix compilation issues and remove commented code

    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    340cb4c View commit details
    Browse the repository at this point in the history

  3. Pass all tests by using correct flagComp lookups in completion command 

    code.
    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    69578f2 View commit details
    Browse the repository at this point in the history

  4. Remove useless duplicate import

    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1548134 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into completion

    @maxlandon
    maxlandon authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e7f1370 View commit details
    Browse the repository at this point in the history

  6. Rename GetFlagCompletionFuncByName() for flag names lookup

    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f5848b6 View commit details
    Browse the repository at this point in the history

  7. Fix a logic lookup bug that was kind enough to surface at the good 

    moment.
    @maxlandon
    maxlandon committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5aadb0d View commit details
    Browse the repository at this point in the history