add fish completion support #754

0robustus1 · 2018-09-26T08:59:08Z

This adds generation of fish autocompletion as suggested in #350.

It should support the following types of completion:

subcommands
- including the deactivation of subcommand completion after a local non-persistent flag
long and short flags (with boolean flags not taking arguments and all other flags requiring an argument)
arguments to subcommands (per ValidArgs and ArgAliases)

@JHK tested the completion by integrating it with kubectl. We are planning to integrate fish completion with kubectl after it is available in cobra.

CLAassistant · 2018-09-26T08:59:15Z

All committers have signed the CLA.

0robustus1 · 2018-09-26T11:40:33Z

It seems that there is a difference of opinion between gofmt in the go-current tests and go-latest.
The same issue seems to occur on current master commits.
Maybe you can take a look as to how this could be resolved? (see also #737)

lwolfsonkin · 2018-12-12T16:15:45Z

bump

wwentland · 2019-01-02T21:02:22Z

It would be lovely to see this merged, so that kubernetes/kubectl#131 can be addressed.

0robustus1 · 2019-01-04T10:35:29Z

@eparis could you take a look at this?

davewongillies · 2019-05-21T16:57:22Z

Sorry for the noise, but @0robustus1 are you going to finish this off?

0robustus1 · 2019-05-21T18:49:18Z

Hi @davewongillies. AFAIK there aren't any action items that would need to be completed.
In a previous comment i mentioned that the test-suite is failing due to a change in gofmt regarding
formatting that isn't compatible with prior versions or future versions (a.k.a. go-current at the time, go-latest and go-previous work fine).

As far as i am concerned this waiting for interaction with the PR by a maintainer, e.g. regarding review or guidance how to proceed with the test-suite (e.g. updating go-current, *-latest and *-previous references). I as well as others have tried reaching the maintainers, but we haven't heard anything so far.

davewongillies · 2019-05-22T01:20:51Z

@0robustus1 so it looks like #737 got merged in earlier in the year, which probably handles the test for go-current failing. I rebased your branch from master in my own fork, reverted your last commit 875c5ee, then created a draft PR and all the tests pass: #865

https://circleci.com/gh/spf13/cobra/1259
https://circleci.com/gh/spf13/cobra/1258
https://circleci.com/gh/spf13/cobra/1257

With the old version flags between subcommands weren't allowed (as it was doing exact match). This solution is still not perfect (as it uses '.+') and could potentially swallow other subcommands.

0robustus1 · 2019-05-22T08:04:47Z

@davewongillies thx, i hadn't noticed that this particular PR got merged. I performed the rebase.

twpayne · 2019-09-09T08:53:42Z

Any chance of this getting merged?

aybabtme · 2019-09-24T22:51:03Z

@spf13 is there someone else than @eparis who could review/approve/merge this? The PR is almost a year old, and it would make a lot of tools much more pleasant to use out in the wild for all fish users.

morozov · 2019-09-24T23:13:11Z

So far, I tried this PR by compiling GoogleContainerTools/skaffold with the patched spf13/cobra, and it produced a working completion. Then I put the generated competition in my dotfiles. It's a PITA but it works. I wish it was accepted sooner so the dependents could pick up the new API.

0robustus1 · 2019-09-27T09:36:34Z

As of yesterday this Pull-Request is officially 1 year old (Happy Birthday btw. 🎉 ).

I'll therefore give this one more try:
@jharshman, @BoGeM and of course @spf13 I'm pinging you because you recently (within 2019) actively pushed commits to this repository. I would ask you to take a look at this Pull-Request if you have some time. It would be highly appreciated. If i can help in any way in furthering the Review (and hopefully subsequent merge) of this Pull-Request along, let me know.

umarcor · 2019-09-30T16:06:48Z

@0robustus1, I feel it pertinent to ref #959 here.

* add fish completion basics to cobra. * add helpCommand check to fish completions. * add basic tests for fish completion. * support ValidArgs completion of commands in fish. * add additional support for argument aliases. * remove oly mention. * use custom function for checking subcommand path. * use fish builtin for flag/argument checking. * backport __fish_seen_argument. * escape description of commands & flags. * allow subcommand_path to match even with flags * deal with unreachable code warning.

dhollinger · 2019-11-14T19:33:25Z

Can we get someone to approve/merge this? @spf13 @eparis ?

Pretty please?

* add fish completion basics to cobra. * add helpCommand check to fish completions. * add basic tests for fish completion. * support ValidArgs completion of commands in fish. * add additional support for argument aliases. * remove oly mention. * use custom function for checking subcommand path. * use fish builtin for flag/argument checking. * backport __fish_seen_argument. * escape description of commands & flags. * allow subcommand_path to match even with flags * deal with unreachable code warning.

floriankoch · 2020-01-23T11:14:17Z

any plans to merge this?

* add fish completion basics to cobra. * add helpCommand check to fish completions. * add basic tests for fish completion. * support ValidArgs completion of commands in fish. * add additional support for argument aliases. * remove oly mention. * use custom function for checking subcommand path. * use fish builtin for flag/argument checking. * backport __fish_seen_argument. * escape description of commands & flags. * allow subcommand_path to match even with flags * deal with unreachable code warning.

nesl247 · 2020-03-27T18:50:53Z

Seems like #1048 may be replacing this.

jharshman · 2020-03-27T19:30:06Z

@nesl247 correct, #1048 will replace this.

z3ntu · 2020-04-14T06:09:37Z

#1048 is merged

xordspar0 · 2020-04-14T13:26:06Z

Great! This can be closed now.

claytonrcarter mentioned this pull request Nov 6, 2018

Add shell completion scripts zaquestion/lab#40

Closed

wwentland mentioned this pull request Nov 8, 2018

Please add fish completion kubernetes/kubectl#131

Closed

This was referenced Jan 11, 2019

Add kubectl completions fish-shell/fish-shell#5516

Closed

Thought about submitting this to oh-my-fish to increase visibility? evanlucas/fish-kubectl-completions#11

Open

wwentland mentioned this pull request Jan 19, 2019

Please add fish tab completion kubernetes/kubectl#576

Closed

0robustus1 force-pushed the 350-add_fish_completion_support branch from 2aa324a to 875c5ee Compare February 15, 2019 12:26

saschagrunert mentioned this pull request Mar 26, 2019

Add fish shell completion containers/podman#2764

Closed

0robustus1 added 12 commits May 22, 2019 09:46

add fish completion basics to cobra.

e949e84

add helpCommand check to fish completions.

65eca9e

add basic tests for fish completion.

4ced144

support ValidArgs completion of commands in fish.

582ef56

add additional support for argument aliases.

68363b7

remove oly mention.

7d2d55a

use custom function for checking subcommand path.

80632ad

use fish builtin for flag/argument checking.

5ee6b23

backport __fish_seen_argument.

157737b

escape description of commands & flags.

01850df

allow subcommand_path to match even with flags

8edc57e

With the old version flags between subcommands weren't allowed (as it was doing exact match). This solution is still not perfect (as it uses '.+') and could potentially swallow other subcommands.

deal with unreachable code warning.

64400ad

0robustus1 force-pushed the 350-add_fish_completion_support branch from 875c5ee to 64400ad Compare May 22, 2019 07:46

davewongillies mentioned this pull request May 22, 2019

Add fish completion support twpayne/chezmoi#320

Merged

twpayne mentioned this pull request Aug 26, 2019

Building for Raspberry PI fail twpayne/chezmoi#408

Closed

sanga mentioned this pull request Sep 1, 2019

add rudimentary fish completions for docker network docker/cli#2066

Merged

nono mentioned this pull request Jan 22, 2020

Add completion for fish shell cozy/cozy-stack#2337

Closed

mislav mentioned this pull request Jan 29, 2020

Add fish completion support cli/cli#271

Merged

2 tasks

umarcor mentioned this pull request Feb 3, 2020

v1.1.0rc #1028

Closed

umarcor mentioned this pull request Feb 11, 2020

Make sure we quote brackets when generating zsh completion #899

Closed

af12066 mentioned this pull request Feb 24, 2020

Support fish on eksctl completion eksctl-io/eksctl#1496

Closed

grampelberg mentioned this pull request Mar 27, 2020

Add fish shell completions linkerd/linkerd2#4208

Closed

jharshman closed this Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add fish completion support #754

add fish completion support #754

0robustus1 commented Sep 26, 2018

CLAassistant commented Sep 26, 2018 •

edited

Loading

0robustus1 commented Sep 26, 2018 •

edited

Loading

lwolfsonkin commented Dec 12, 2018

wwentland commented Jan 2, 2019

0robustus1 commented Jan 4, 2019

davewongillies commented May 21, 2019

0robustus1 commented May 21, 2019

davewongillies commented May 22, 2019

0robustus1 commented May 22, 2019

twpayne commented Sep 9, 2019

aybabtme commented Sep 24, 2019 •

edited

Loading

morozov commented Sep 24, 2019

0robustus1 commented Sep 27, 2019

umarcor commented Sep 30, 2019

dhollinger commented Nov 14, 2019

floriankoch commented Jan 23, 2020

nesl247 commented Mar 27, 2020

jharshman commented Mar 27, 2020

z3ntu commented Apr 14, 2020

xordspar0 commented Apr 14, 2020

add fish completion support #754

add fish completion support #754

Conversation

0robustus1 commented Sep 26, 2018

CLAassistant commented Sep 26, 2018 • edited Loading

0robustus1 commented Sep 26, 2018 • edited Loading

lwolfsonkin commented Dec 12, 2018

wwentland commented Jan 2, 2019

0robustus1 commented Jan 4, 2019

davewongillies commented May 21, 2019

0robustus1 commented May 21, 2019

davewongillies commented May 22, 2019

0robustus1 commented May 22, 2019

twpayne commented Sep 9, 2019

aybabtme commented Sep 24, 2019 • edited Loading

morozov commented Sep 24, 2019

0robustus1 commented Sep 27, 2019

umarcor commented Sep 30, 2019

dhollinger commented Nov 14, 2019

floriankoch commented Jan 23, 2020

nesl247 commented Mar 27, 2020

jharshman commented Mar 27, 2020

z3ntu commented Apr 14, 2020

xordspar0 commented Apr 14, 2020

CLAassistant commented Sep 26, 2018 •

edited

Loading

0robustus1 commented Sep 26, 2018 •

edited

Loading

aybabtme commented Sep 24, 2019 •

edited

Loading