Add map valued (string->string, string->int) flags.

[tamalsaha]

Format: --myflag=a=1,b=2

ref: #129

[CLAassistant]

All committers have signed the CLA.

[tamalsaha]

@eparis, mind taking a look?

[sgraham785]

@tamalsaha why was this closed? it's still a useful implementation unless there is now some other way to accomplish now?

[tamalsaha]

Because it did not seem that it will get merged. Our fork is maintained.

[eparis]

somehow I totally missed this.... sorry....

[eparis]

Should this actually be a CSV decode, instead of just splitting on ,? What is there is a comma in the value?

[tamalsaha]

Thanks @eparis ! I have addressed your comment. PTAL.

[eparis]

that's really awesome! If you'll write a test of the csv stuff, I'll merge it!

[tamalsaha]

If you'll write a test of the csv stuff, I'll merge it!

I added some tests here:

• https://github.com/spf13/pflag/pull/133/files#diff-5f559d5cd1fe9b2d957bdc7eee7c427dR63
• https://github.com/spf13/pflag/pull/133/files#diff-5f559d5cd1fe9b2d957bdc7eee7c427dR116

[tamalsaha]

Added even more tests, Search for 5,6, 7,8 . PTAL.

[sgraham785]

this is awesome thanks guys! 💯

[yashbhutwala]

@tamalsaha Does StringToStringVar support --myflag=a=1,b=2,3. I tried it and it didn't work for me, so not sure, if I'm using it wrong, or the functionality is missing.

[tamalsaha]

It is not supported.See the comment #179

[yashbhutwala]

I see, OK. This comment indicates that --f3 "c=5,6",d=7 is possible, however, I haven't been able to use it.

[tamalsaha]

Try passing this flag like this --myflag a=1,"b=2,3" . It should work.

[yashbhutwala]

Nope, getting an error: flag: 3 must be formatted as key=value

[tamalsaha]

Here is the code that does the parsing. https://github.com/spf13/pflag/pull/179/files#diff-1ace98db8b8888abf672baa63775bc05R24

This should work: https://play.golang.org/p/rIAPpDsiHJQ The code is using CSV reader. Did you use the double quote?

[yashbhutwala]

OK @tamalsaha this worked for me: --f3 'a=1,"b=5,6"'. So instead of `` wrapping the whole parameter, it's ''. Thanks so much for your swift responses! :D