Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added String-To-Int64 option parsing #211

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Added String-To-Int64 option parsing #211

merged 1 commit into from
Aug 14, 2019

Conversation

Cyberax
Copy link

@Cyberax Cyberax commented Jun 28, 2019

Add support for "map[string]int64" options.

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

therealmitchconnors
therealmitchconnors approved these changes Aug 13, 2019
View reviewed changes
Copy link
Collaborator

@therealmitchconnors therealmitchconnors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that these changes are essentially copies of the string_to_int*.go files, with all the relevant parts updated to 64 bit. Even the 2009 copyright is copied ;). Approve.

@eparis
Copy link
Collaborator

eparis commented Aug 14, 2019

hard to argue with that review.

@eparis eparis merged commit 9722382 into spf13:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealmitchconnors therealmitchconnors therealmitchconnors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Cyberax @CLAassistant @eparis @therealmitchconnors