Export all *Value types #341
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote reuse and make it convenient for users to create and add these Value types hand-crafted pflag.Flag structs when the helper functions can't be used and the raw pflag.Flag value is desired, so it can be passed to FlagSet.AddFlag(). Fixes: spf13#334 Signed-off-by: Joe Groocock <me@frebib.net>
|
|
|
This is needed, but why not export all the other flag types like duration, bool, etc? To make these even more useful we should export the new functions like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote reuse and make it convenient for users to create and add these
Value types hand-crafted pflag.Flag structs when the helper functions
can't be used and the raw pflag.Flag value is desired, so it can be
passed to FlagSet.AddFlag().
Fixes: #334
Signed-off-by: Joe Groocock me@frebib.net