support VarPF variantes for options to return created flags #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mandelsoft
force-pushed
the
master
branch
2 times, most recently
from
e79b13d
to
8329072
Compare
The actuals variants of the flag creation do not report back the generated Flag object. But this would be reqired to do further tweaking according to the public fields of a Flag, like adding of annotations. Therefore it would be useful to have an additional variant of the option creation methods on a FlagSet, which returns the generated Flag object. The underlying method VarPF already exists and can directly be used to support appropriate VarPF variants for the type specific methods. For example func (f *FlagSet) StringVarPF(p *string, name, shorthand string, value string, usage string) *Flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actuals variants of the flag creation do not report back the generated Flag object. But this would be reqired to do further tweaking according to the public fields of a Flag, like adding of annotations.
Therefore it would be useful to have an additional variant of the option creation methods on a FlagSet, which returns the generated Flag object.
The underlying method VarPF already exists and can directly be used to support appropriate VarPF variants for the type specific methods.
For example
func (f *FlagSet) StringVarPF(p *string, name, shorthand string, value string, usage string) *Flag