Merge defaults when Get()'ing maps #1439
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for contributing to Viper! You are awesome! 🎉 A maintainer will take a look at your pull request shortly. 👀 In the meantime: We are working on Viper v2 and we would love to hear your thoughts about what you like or don't like about Viper, so we can improve or fix those issues. ⏰ If you have a couple minutes, please take some time and share your thoughts: https://forms.gle/R6faU74qPRPAzchZ9 📣 If you've already given us your feedback, you can still help by spreading the news, https://twitter.com/sagikazarmark/status/1306904078967074816 Thank you! ❤️ |
|
|
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 29, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version.
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 29, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version.
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 29, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version.
|
Note: this is only a partial solution for defaults. Similar issues exist across other layers (flags, overrides). |
|
I've updated the pull with a more complete solution that considers all layers. |
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 30, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version.
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 30, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Sep 30, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Oct 1, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Oct 1, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Oct 3, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Oct 3, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
setrofim
added a commit
to veraison/services
that referenced
this pull request
Oct 3, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
When fetching a configuration sub-tree (either via Get() that results in a map, or through Sub()), ensure that any defaults for keys under that tree are propagated into the returned result. Fixes spf13#747 Signed-off-by: setrofim <setrofim@gmail.com>
SabreenKaur
pushed a commit
to veraison/services
that referenced
this pull request
Oct 7, 2022
Viper currently has a bug where defaults do not get properly propagated when extracting a configuration sub-tree. See spf13/viper#747 A pull request has been opened with a potential fix: spf13/viper#1439 Until the fix (or some alternative) gets merged, switch to using the forked version. Signed-off-by: Sergei Trofimov <sergei.trofimov@arm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fetching a configuration sub-tree (either via Get() that results in a map, or through Sub()), ensure that any defaults for keys under that tree are propagated into the returned result.
Fixes #747
Signed-off-by: setrofim setrofim@gmail.com