Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New encoding layer #1869

Merged
merged 9 commits into from
Jun 24, 2024
Merged

New encoding layer #1869

merged 9 commits into from
Jun 24, 2024

Conversation

sagikazarmark
Copy link
Collaborator

@sagikazarmark sagikazarmark commented Jun 21, 2024

Expose a new encoding abstraction layer. It allows users to bring their own encoding logic into Viper.

It also allows moving some of the less used formats (HCL, INI, Java properties) out of the core.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the release-note/new-feature Release note: Exciting New Features label Jun 21, 2024
encoding.go Outdated Show resolved Hide resolved
Repository owner deleted a comment from github-actions bot Jun 21, 2024
@sagikazarmark
Copy link
Collaborator Author

@skitt @andig could use a pair of extra eyes on this.

This was referenced Jun 21, 2024
encoding.go Show resolved Hide resolved
viper.go Outdated Show resolved Hide resolved
@andig
Copy link
Contributor

andig commented Jun 22, 2024

It also allows moving some of the less used formats (HCL, INI, Java properties) out of the core.

@sagikazarmark this still does not remove the go.mod dependencies, or does it?

@sagikazarmark
Copy link
Collaborator Author

@andig not yet. This is just the first step to still allow using those libraries once they are removed.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
encoding.go Outdated Show resolved Hide resolved
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark
Copy link
Collaborator Author

I think this is ready

@sagikazarmark sagikazarmark merged commit e033c8e into master Jun 24, 2024
27 checks passed
@sagikazarmark sagikazarmark deleted the encoding2 branch June 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/new-feature Release note: Exciting New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants