Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only invoke env.note_dependency() when there is a source file #83

Conversation

oharboe
Copy link
Contributor

@oharboe oharboe commented Aug 11, 2021

No description provided.

@dhellmann
Copy link
Member

I'm not sure what note_dependency() does. Can you add some details about why this is a useful change to the commit message?

@oharboe
Copy link
Contributor Author

oharboe commented Aug 11, 2021

I'm not sure what note_dependency() does. Can you add some details about why this is a useful change to the commit message?

This function should only be called with files. It is being invoked with a directory in the case that there's no source file to depend on. This must be unintentional.

Calling it with a folder, causes other sphinx plugins to fail as they see folders as dependencies, which is illegal.

Such as in mgeier/sphinx-last-updated-by-git#27

@oharboe oharboe force-pushed the add-note-dependency-only-when-there-is-a-source-file branch from 979bc30 to 940b16a Compare August 12, 2021 08:17
@dhellmann dhellmann merged commit b846f5f into sphinx-contrib:master Aug 28, 2021
@dhellmann
Copy link
Member

This PR was released in version 0.9.1. https://doughellmann.com/releases/sphinxcontrib-datatemplates-0-9-1/

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants