Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build badge #58

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Fix build badge #58

merged 1 commit into from
Mar 30, 2023

Conversation

hugovk
Copy link
Collaborator

@hugovk hugovk commented Mar 30, 2023

badges/shields#8671 says:

You need to update your badge URL from

https://img.shields.io/github/workflow/status/<user>/<repo>/Run%20Tests
to
https://img.shields.io/github/actions/workflow/status/<user>/<repo>/test.yml?branch=main

Before

image

After

image

@hugovk
Copy link
Collaborator Author

hugovk commented Mar 30, 2023

The 3.7 failure is unrelated to this PR.

It's a syntax error caused by this new file in CPython main that uses the walrus operator, new in 3.8:

https://github.com/python/cpython/blob/21e9de3bf0ecf32cd61296009518bfb9fdfcd04f/Doc/tools/warnings-to-gh-actions.py#L22

We should skip it somehow.

@JulienPalard
Copy link
Collaborator

Rebasing on top of #59 should do it.

@JulienPalard JulienPalard merged commit d9d5ab4 into sphinx-contrib:main Mar 30, 2023
@JulienPalard
Copy link
Collaborator

Thanks!

@hugovk hugovk deleted the patch-1 branch March 31, 2023 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @JulienPalard