-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github linkcheck anchor change in 4.1.0 break some usage #9435
Comments
A simple fix here would be for the linkcheck logic to simply exclude links of the form But of course really the current logic is broken for any link that's generated by github itself and thus doesn't have this prefix. |
Agreed. Here's a subset of native GitHub anchor prefixes that are currently broken in Sphinx 4.1.0: |
Yes, it's a pretty unfortunate circumstance. It's not at all surprising github doesn't make a list of these, I haven't seen any website with a list of their anchor refs! ATM I'm interested in whatever solution will get this back to a working state as quickly as possible. |
Completely untested but my understanding of the original PR is that it attempts to fix the linkchecking of anchors in the scenario of a rendered rST/Markdown file. As an immediate patch, would it help to add an additional check to the |
OMG! I must admit our approach in #9016 is wrong. So we have to reconsider the way to check the anchors in reST/MD files. Until then, we have to fix the broken linkcheck-builder. I think it's better to disable |
That'd be fine with me :-) |
In #9260 a new |
The approach of `rewrite_github_anchor` makes some anchors valid. But it also makes other kind of anchors invalid. This disables the handler to make them valid again (while 4.1.x release).
I don't think so. The |
Fix #9435: linkcheck: Failed to check anchors in github.com
Looks like everything in the 4.1.2 milestone is complete. Should we expect a release soon? |
@alex Please wait a moment. I did not read other issues yet. Some issues might be added to the milestone after that. But I understand this issue is also important. So I'll ship 4.1.2 this weekend even if some issues will not be resolved. |
Thanks!
בתאריך יום ג׳, 20 ביולי 2021, 13:11, מאת Takeshi KOMIYA <
***@***.***>:
… @alex <https://github.com/alex> Please wait a moment. I did not read
other issues yet. Some issues might be added to the milestone after that.
But I understand this issue is also important. So I'll ship 4.1.2 this
weekend even if some issues will not be resolved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9435 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBGR22VCXXSO5EDYXC3TYWU55ANCNFSM5AGZON4A>
.
|
Describe the bug
Given a link like:
in a github doc, with release 4.1.0 this will fail with linkcheck, while previously it worked.
How to Reproduce
Expected behavior
It passes.
Your project
https://github.com/pyca/cryptography
Screenshots
No response
OS
Linux
Python version
3.9.5
Sphinx version
4.1.0
Sphinx extensions
No response
Extra tools
No response
Additional context
The relevant change happened in 92335bd
Failing test logs: https://github.com/pyca/cryptography/runs/3046691393
The text was updated successfully, but these errors were encountered: