Extend linkchecker GET fallback logic to handle Too Many Redirects #8475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some websites will enter infinite redirect loops with HEAD requests. In this case, the GET fallback is ignored as the exception is of type TooManyRedirects and the link is reported as broken. This extends the except clause to retry with a GET request for such scenarios.
… treated as broken
|
@francoisfreitag Do you have any opinion for this? |
francoisfreitag
approved these changes
Nov 22, 2020
Co-authored-by: François Freitag <mail@franek.fr>
|
Thank you for reviewing :-) I'll merge this soon after testing passed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Purpose