Extend linkchecker GET fallback logic to handle Too Many Redirects #8131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some websites will enter infinite redirect loops with HEAD requests. In this case, the GET fallback is ignored as the exception is of type TooManyRedirects and the link is reported as broken. This extends the except clause to retry with a GET request for such scenarios.
|
@tk0miya any feedback on whether this change might be considered for cherry-picking somewhere else of whether it is unconditionally closed (and if so, what is the rationale)? |
|
OMG. It's an accident. I did not notice PR for the 3.2.x branch. I think this fix is worthy. So I'll merge this soon. |
tk0miya
added a commit
to tk0miya/sphinx
that referenced
this pull request
Nov 22, 2020
… treated as broken
|
I cherry-picked the commit and posted a new PR as #8475. Sorry for my bad and thank you for your contribution! |
|
No worries, thanks for cherry-picking and starting the discussion in #8475 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: linkcheck - fallback to GET requests when HEAD requests returns Too Many Redirects
Feature or Bugfix
Purpose
Some websites will enter infinite redirect loops with HEAD requests. In this case, the GET fallback is ignored as the exception is of type
TooManyRedirectsand the link is reported as broken.This extends the except clause to retry with a GET request for such scenarios.
Detail
Classifying this as a bug fix as URLs like https://idr.openmicroscopy.org/webclient/?show=well-119093 used to pass the linkchecking prior to Sphinx 3.2.0 but are now failing as HEAD requests have been enforced (#7936).
/cc @mtbc @jburel @manics @joshmoore