-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pg): Support Astar zkEVM, Mantle, Crab, Darwinia #1694
feat(pg): Support Astar zkEVM, Mantle, Crab, Darwinia #1694
Conversation
dae51d1
to
b30f7c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor comments
README.md
Outdated
@@ -135,6 +139,8 @@ Test networks: | |||
- Blast Sepolia | |||
- Darwinia Pangolin | |||
- Taiko Katla | |||
- Mantle Sepolia | |||
- Astar zkyoto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zkyoto -> zKyoto
packages/contracts/src/networks.ts
Outdated
}, | ||
{ | ||
name: 'astar_zkyoto', | ||
displayName: 'Astar zkEVM zkyoto', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be consistent with the name in the main readme, i.e. "Astar zKyoto"
README.md
Outdated
@@ -110,6 +110,10 @@ Please feel free to reach out to us in our [Discord](https://discord.gg/7Gc3DK33 | |||
- Rootstock | |||
- Blast | |||
- Mode | |||
- Mantle | |||
- Darwinia | |||
- Darwinia Crab |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the standard name for this network is just Crab. https://chainlist.org/?search=crab&testnets=true
b30f7c6
to
47ff653
Compare
47ff653
to
89d421b
Compare
Purpose
Adds support for all of the networks that Darwinia requested.