Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pg): Support Astar zkEVM, Mantle, Crab, Darwinia #1694

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

RPate97
Copy link
Collaborator

@RPate97 RPate97 commented Apr 28, 2024

Purpose

Adds support for all of the networks that Darwinia requested.

@RPate97 RPate97 force-pushed the pate/chu-945-support-darwinias-requested-networks branch from dae51d1 to b30f7c6 Compare April 28, 2024 20:36
Copy link
Collaborator

@sam-goldman sam-goldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments

README.md Outdated
@@ -135,6 +139,8 @@ Test networks:
- Blast Sepolia
- Darwinia Pangolin
- Taiko Katla
- Mantle Sepolia
- Astar zkyoto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zkyoto -> zKyoto

},
{
name: 'astar_zkyoto',
displayName: 'Astar zkEVM zkyoto',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be consistent with the name in the main readme, i.e. "Astar zKyoto"

README.md Outdated
@@ -110,6 +110,10 @@ Please feel free to reach out to us in our [Discord](https://discord.gg/7Gc3DK33
- Rootstock
- Blast
- Mode
- Mantle
- Darwinia
- Darwinia Crab
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the standard name for this network is just Crab. https://chainlist.org/?search=crab&testnets=true

@RPate97 RPate97 force-pushed the pate/chu-945-support-darwinias-requested-networks branch from b30f7c6 to 47ff653 Compare April 29, 2024 17:26
@RPate97 RPate97 force-pushed the pate/chu-945-support-darwinias-requested-networks branch from 47ff653 to 89d421b Compare April 29, 2024 20:57
@RPate97 RPate97 merged commit dff64c2 into develop Apr 29, 2024
8 checks passed
@RPate97 RPate97 deleted the pate/chu-945-support-darwinias-requested-networks branch April 29, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants