fix(new-releases): use hardcoded queryArtistDiscographyAll def
#3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the getArtistEverything function in the new-releases index.js file. Instead of using the Spicetify.GraphQL.Definitions object, the function now directly passes the necessary parameters to the Spicetify.GraphQL.Request function. This change improves code readability and maintainability.
ohitstom
changed the title
ohitstom
changed the title
ohitstom
changed the title
rxri
approved these changes
Sep 12, 2024
ohitstom
changed the title
|
run biome |
rxri
changed the title
queryArtistDiscographyAll def
i did, i think its failing cause of the title edit: oh its failing on a file i didnt even change? |
ohitstom
changed the title
queryArtistDiscographyAll defqueryartistdiscographyall def
ohitstom
changed the title
queryartistdiscographyall defqueryArtistDiscographyAll def
|
Thank you so much for fixing New Releases, I downloaded the new-releases index.js and put it in my spicetify files, it works again <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the getArtistEverything function in the new-releases index.js file. Instead of using the Spicetify.GraphQL.Definitions object, the function now directly passes the necessary parameters to the Spicetify.GraphQL.Request function. This change improves code readability and maintainability.
^ first time using the AI commit name thing lol, pretty accurate but we are using the graphql hash because 1.2.46 no longer has this graphql definition