Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(snippets): remove Hide Upgrade Button #661

Merged
merged 4 commits into from
Nov 30, 2023
Merged

chore(snippets): remove Hide Upgrade Button #661

merged 4 commits into from
Nov 30, 2023

Conversation

SunsetTechuila
Copy link
Contributor

Hide Upgrade Button

adblock does this

Better lyrics style

poorly made + beautiful lyrics extensions or bloom theme do the job better

@SunsetTechuila SunsetTechuila requested a review from a team as a code owner November 30, 2023 20:54
@SunsetTechuila SunsetTechuila requested review from rxri and removed request for a team November 30, 2023 20:54
theRealPadster
theRealPadster requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the point in removing the "hide upgrade button" one, but the better lyrics one looks like it does work and provides a different UI for the lyrics, and at a lighter cost than running an extension

@SunsetTechuila SunsetTechuila changed the title chore(snippets): remove some chore(snippets): remove Hide Upgrade Button Nov 30, 2023
@SunsetTechuila
Copy link
Contributor Author

if you insist

theRealPadster
theRealPadster requested changes Nov 30, 2023
View reviewed changes
Copy link
Member

@theRealPadster theRealPadster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we can also remove the thumbnail image if we are removing the snippet.

@theRealPadster theRealPadster merged commit fe1561a into spicetify:main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theRealPadster theRealPadster theRealPadster approved these changes

@rxri rxri Awaiting requested review from rxri rxri is a code owner automatically assigned from spicetify/marketplace

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SunsetTechuila @theRealPadster