ci: Add automatic update of spiderpool authors #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ty-dc
force-pushed
the
auto-check-authors-x
branch
3 times, most recently
from
4bffe6d
to
02ff7e8
Compare
weizhoublue
reviewed
May 23, 2024
Makefile
Outdated
| @@ -499,3 +499,10 @@ lint_chart_trivy: | |||
| .PHONY: build-chart | |||
| build-chart: | |||
| @ cd charts ; make | |||
|
|
|||
| update-authors: | |||
There was a problem hiding this comment.
185 行已经有 update-author ， 作用类似 ？ 建议保持 makefile 的干净，不需要这么多，进行必要的整合
然后这个target 的位置 放在 makefile 合适的位置，不是 随意的加在最后
weizhoublue
reviewed
May 23, 2024
tools/scripts/extract_authors.sh
Outdated
|
|
||
| # exclusion list | ||
| # Exclude bots and non-compliant lists | ||
| excluded_name=("dependabot[bot]" "root" "weizhou.lan@daocloud.io") |
There was a problem hiding this comment.
不是一个“真的”贡献者？没有必要加到 authors 里面吧？
weizhoublue
reviewed
May 23, 2024
AUTHORS
Outdated
| swatchgame a865316182@gmail.com | ||
| twoodpecker tysuper@yeah.net | ||
| weizhouBlue weizhou.lan@daocloud.io |
There was a problem hiding this comment.
这里有bug 就是， 我早期用 weizhouBlue ， 后来用 weizhoublue ， 对应同一个 email
那么应该取为 最新的 weizhoublue
ty-dc
force-pushed
the
auto-check-authors-x
branch
8 times, most recently
from
29b61cd
to
96dd279
Compare
weizhoublue
reviewed
May 25, 2024
|
|
||
| # Copyright 2024 Authors of spidernet-io | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
There was a problem hiding this comment.
shell 代码 健壮性太差
shell 代码顶部 应该有常规的 set -x 等之类的 返回码异常 判断，加强健壮性
weizhoublue
reviewed
May 25, 2024
Makefile
Outdated
| @@ -181,13 +181,12 @@ dev-doctor: | |||
|
|
|||
| #============ tools ==================== | |||
|
|
|||
| .PHONY: update-authors | |||
| update-authors: ## Update AUTHORS file for the repository. | |||
| update-authors: | |||
| @echo "Updating AUTHORS file..." | |||
| @echo "The following people, in alphabetical order, have either authored or signed" > AUTHORS | |||
There was a problem hiding this comment.
如果 extractAuthors.sh 有失败，这里直接 已经 提前 其他把 文件清空了，就会有 bug ，提交一份错的 空文件上来
There was a problem hiding this comment.
先用 变量 存住 脚本输出，判断返回码，再 打印到文件
weizhoublue
reviewed
May 25, 2024
|
|
||
| - name: update authors of spiderpool | ||
| run: | | ||
| make update-authors |
There was a problem hiding this comment.
这里没有任何返回码的判断，如果直接失败了，产生的文件 可能是错的，这里直接提交 错误的
ty-dc
force-pushed
the
auto-check-authors-x
branch
from
96dd279
to
46a1163
Compare
Signed-off-by: tao.yang <tao.yang@daocloud.io> Signed-off-by: ty-dc <tao.yang@daocloud.io>
ty-dc
force-pushed
the
auto-check-authors-x
branch
from
46a1163
to
992ebb5
Compare
weizhoublue
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: