Implements Federated Bundle Fetching #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: martincapello <m.a.capello@gmail.com>
Signed-off-by: martincapello <m.a.capello@gmail.com>
azdagron
reviewed
Apr 8, 2020
v2/federation/fetch.go
Outdated
Comment on lines
25
to
27
| var defaultFetchOptions = fetchOptions{ | ||
| transport: http.DefaultTransport, | ||
| } |
There was a problem hiding this comment.
Hmm, how would you feel about transport being a concrete *http.Transport instead of a round tripper? The default could then be a copy of the default http transport:
defaultTransport := *http.DefaultTransport.(*http.Transport)
transport = &defaultTransport
I think there is value in preserving the default transport behavior even when we replace the TLS config for SPIFFE auth.
|
🤦♂️ you are right! |
In the above line I got: |
|
Oh shoot. Yes. Instead use |
Signed-off-by: martincapello <m.a.capello@gmail.com>
azdagron
pushed a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: martincapello <m.a.capello@gmail.com>
marcosy
pushed a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: martincapello <m.a.capello@gmail.com>
azdagron
pushed a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: martincapello <m.a.capello@gmail.com>
martincapello
added a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: martincapello <m.a.capello@gmail.com>
amartinezfayo
pushed a commit
that referenced
this pull request
Apr 22, 2020
Signed-off-by: martincapello <m.a.capello@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
Unit test are in progress and will be pushed in a new PR.