Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Commit

Permalink
Switch the spire tests to always run (#250)
Browse files Browse the repository at this point in the history
This patch sets the spire chart tests to always run. This enables
changes in tests to be tested and sets a base for split out charts.

---------

Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
  • Loading branch information
kfox1111 authored May 15, 2023
1 parent 8c5643b commit 8d9b734
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions .github/workflows/helm-chart-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,14 +92,6 @@ jobs:
with:
version: ${{ env.CHART_TESTING_VERSION }}

- name: Run chart-testing (list-changed)
id: list-changed
run: |
changed=$(ct list-changed --target-branch ${{ github.base_ref }})
if [[ -n "$changed" ]]; then
echo "changed=true" >> $GITHUB_OUTPUT
fi
- name: Run chart-testing (lint)
run: |
ct lint --debug ${{ github.base_ref != 'release' && '--check-version-increment=false' || '' }} \
Expand All @@ -114,8 +106,6 @@ jobs:

needs: [lint-chart]

if: needs.lint-chart.outputs.changed == 'true'

steps:
- name: Checkout
uses: actions/checkout@v3.5.2
Expand All @@ -137,8 +127,6 @@ jobs:
- lint-chart
- build-matrix

if: needs.lint-chart.outputs.changed == 'true'

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -209,6 +197,7 @@ jobs:
"${TEST_DIR}/install.sh"
else
ct install --debug \
--charts "charts/spire" \
--namespace "${scenario}" \
--target-branch ${{ github.base_ref }} \
--exclude-deprecated \
Expand Down

0 comments on commit 8d9b734

Please sign in to comment.