Change spire configmaps to yaml, rendered as json

[marcofranssen]

• Change spire-server configmap to yaml rendered as JSON
• Change spire-agent configmap to yaml rendered as JSON
• Change spiffe-oidc-discovery-provider configmap to yaml rendered as JSON
• Bump min required spire 1.6.x version for this chart

resolves #86

[kfox1111]

Here's one that works attached. seems to be maybe a slight formatting issue:

{
  "health_checks": {
    "bind_address": "0.0.0.0",
    "bind_port": "8080",
    "listener_enabled": true,
    "live_path": "/live",
    "ready_path": "/ready"
  },
  "plugins": {
    "DataStore": [
      {
        "sql": {
          "plugin_data": {
            "connection_string": "/run/spire/data/datastore.sqlite3",
            "database_type": "sqlite3"
          }
        }
      }
    ],
    "KeyManager": [
      {
        "disk": {
          "plugin_data": {
            "keys_path": "/run/spire/data/keys.json"
          }
        }
      }
    ],
    "NodeAttestor": [
      {
        "k8s_psat": {
          "plugin_data": {
            "clusters": {
              "example-cluster": {
                "service_account_allow_list": [
                  "default:spire-agent"
                ]
              }
            }
          }
        }
      }
    ],
    "Notifier": [
      {
        "k8sbundle": {
          "plugin_data": {
            "config_map": "spire-bundle",
            "namespace": "default"
          }
        }
      }
    ]
  },
  "server": {
    "bind_address": "0.0.0.0",
    "bind_port": "8081",
    "ca_key_type": "rsa-2048",
    "ca_subject": [
      {
        "common_name": "example.org",
        "country": [
          "NL"
        ],
        "organization": [
          "Example"
        ]
      }
    ],
    "data_dir": "/run/spire/data",
    "default_jwt_svid_ttl": "1h",
    "default_x509_svid_ttl": "1h",
    "jwt_issuer": "oidc-discovery.example.org",
    "log_level": "info",
    "trust_domain": "example.org"
  }
}

[kfox1111]

K. there were 3 things I needed to change to get it to start.

Put the array down one level. like:

-  - DataStore:
-      sql:
+    DataStore:
+    - sql:

Second, the service_account_allow_list array is already an array. so remove the - from it.

Third, there is a bug in 1.6.0 and 1.6.1 reguarding json loading. its fixed in trunk but not released yet: spiffe/spire#3939. For testing, can use the 1.5.4 version of the server.

[kfox1111]

Just the one little change that I can see. The rest looks good.

[marcofranssen]

Rebased to have the federation option also included.

[kfox1111]

This kind of looks like the production-example test is not actually failing like it should?

[kfox1111]

Yeah. There is an issue with the prod test. Fix is here: #183

[kfox1111]

Also, due to merge ordering, we lost the nightly appVersion in the charts which is why all the tests are failing.

[kfox1111]

Maybe I should have mentioned. All the suggestions would have to go in all at once to work, as its one patch.

[kfox1111]

I'm not sure how, but the pr seems to have lost its '-'s for each plugin.

[kfox1111]

Besides the issue in the suggestion, I think there is one more issue and this can merge.

charts/spire/README.md.gotmpl:| SPIRE | 1.5.3+, 1.6.x |
should be adjusted to 1.6.3+

same with README.md

[kfox1111]

LGTM