Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Add namespace to spiffe-oidc-discovery-provider RBAC definitions #379

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Add namespace to spiffe-oidc-discovery-provider RBAC definitions #379

merged 1 commit into from
Jul 6, 2023

Conversation

drewwells
Copy link
Contributor

…t namespace

@drewwells
objects did not specify namespace so could be created in the incorrec…
7e8f604 
…t namespace

Signed-off-by: Drew Wells <dwells@infoblox.com>
kfox1111
kfox1111 approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@kfox1111 kfox1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks for fixing this. LGTM

faisal-memon
faisal-memon approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@faisal-memon faisal-memon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @drewwells

@faisal-memon
Copy link
Contributor

Tests arent running, does this need a rebase?

marcofranssen
marcofranssen approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@marcofranssen marcofranssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 rerunning the failed test now succeeded.

@marcofranssen marcofranssen changed the title objects did not specify namespace so could be created in the incorrec… Add namespace to spiffe-oidc-discovery-provider RBAC definitions Jul 6, 2023
@marcofranssen marcofranssen enabled auto-merge (squash) July 6, 2023 07:17
@drewwells
Copy link
Contributor Author

can i get a merge?

@kfox1111
Copy link
Contributor

kfox1111 commented Jul 6, 2023

Its set to automerge, but something is wrong with the tests. @faisal-memon, looks like example-test (v1.27.2, examples/production) is expected, but the test here is test (v1.25.9, production-example). Looks like that has something to do with the test refactoring pr? Is that something you can fix? I don't have permissions to fix that.

@marcofranssen marcofranssen merged commit 4ad68b1 into spiffe:main Jul 6, 2023
@faisal-memon faisal-memon added this to the 0.11.0 milestone Jul 6, 2023
marcofranssen added a commit that referenced this pull request Jul 19, 2023
@marcofranssen
Bump spire Helm Chart version from 0.10.1 to 0.11.0
4dc67c0 
* 088b296 Improve tornjak service API to have object structure (#392)
* 522066e Align tornjak clientCA naming convention (#393)
* f05cb4f Add option to configure TLS/mTLS endpoint for Tornjak (#338)
* f461a01 Bump test chart dependencies (#386)
* ce39e82 Bump test chart dependencies (#382)
* 19d3208 Fix oidc provider config change not rolling out (#383)
* 0197621 Bump helm/kind-action from 1.7.0 to 1.8.0 (#384)
* 3ed1859 Add missing tolerations config to daemonsets (#381)
* 4ad68b1 Add namespace to spiffe-oidc-discovery-provider RBAC definitions (#379)
* c1b1dd3 Add additional domains to JWT issued items. (#230)
* 3405e13 Bump test chart dependencies
* 81452d5 Fix missing spiffe-csi-driver imagePullSecrets template (#376)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
marcofranssen added a commit that referenced this pull request Jul 19, 2023
@marcofranssen
Bump spire Helm Chart version from 0.10.1 to 0.11.0
a981c7d 
* 94a2b72 Merge pull request #324 from spiffe/enable-testing-multiple-charts
* e426bc0 Downgrade chart-testing tool to 3.8.0
* 09b4664 Utilize ct install --github-groups in ci workflow
* 42086bd Run example tests also on all k8s versions
* 4848c48 Improve Makefile help and implementation
* db06038 Increase some timeouts, trying to fix the tests
* 54ed71f Add back tests for examples
* 4b4cef1 Skip namespace-override test because of #330
* 380979c Prevent ci folder ending up in Helm package
* 06ddb7c Use chart-testing ci/*-values.yaml for testing
* a4c1de7 Add basic unit test framework (#390)
* 088b296 Improve tornjak service API to have object structure (#392)
* 522066e Align tornjak clientCA naming convention (#393)
* f05cb4f Add option to configure TLS/mTLS endpoint for Tornjak (#338)
* f461a01 Bump test chart dependencies (#386)
* ce39e82 Bump test chart dependencies (#382)
* 19d3208 Fix oidc provider config change not rolling out (#383)
* 0197621 Bump helm/kind-action from 1.7.0 to 1.8.0 (#384)
* 3ed1859 Add missing tolerations config to daemonsets (#381)
* 4ad68b1 Add namespace to spiffe-oidc-discovery-provider RBAC definitions (#379)
* c1b1dd3 Add additional domains to JWT issued items. (#230)
* 3405e13 Bump test chart dependencies
* 81452d5 Fix missing spiffe-csi-driver imagePullSecrets template (#376)

Signed-off-by: Marco Franssen <marco.franssen@gmail.com>
@marcofranssen marcofranssen mentioned this pull request Jul 19, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@faisal-memon faisal-memon faisal-memon approved these changes

@kfox1111 kfox1111 kfox1111 approved these changes

@marcofranssen marcofranssen marcofranssen approved these changes

@developer-guy developer-guy Awaiting requested review from developer-guy

@dfeldman dfeldman Awaiting requested review from dfeldman

@mrsabath mrsabath Awaiting requested review from mrsabath

@edwbuck edwbuck Awaiting requested review from edwbuck

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@drewwells @faisal-memon @kfox1111 @marcofranssen