Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ttl flag #5254

Closed
azdagron opened this issue Jun 25, 2024 · 5 comments
Closed

Remove deprecated ttl flag #5254

azdagron opened this issue Jun 25, 2024 · 5 comments
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Milestone
1.11.0

Comments

@azdagron
Copy link
Member

azdagron commented Jun 25, 2024 •
edited
Loading

The CLI has long since deprecated the -ttl flag in favor of the SVID specific flags -x509SVIDTTL and -jwtSVIDTTL. The deprecated flag should be removed.
@azdagron azdagron added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Jun 25, 2024
@azdagron azdagron added this to the 1.11.0 milestone Jun 25, 2024
@ayushrakesh
Copy link

@azdagron I want to work on this issue, can you explain it more?

@amoore877
Copy link
Member

@ayushrakesh see https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/create.go#L51 , https://github.com/spiffe/spire/blob/main/cmd/spire-server/cli/entry/update.go#L48

	// TTL for x509 and JWT SVIDs issued to this workload, unless type specific TTLs are set.
	// This field is deprecated in favor of the x509SVIDTTL and jwtSVIDTTL fields and will be
	// removed in a future release.

we want to remove ttl flag entirely in favor of the credential primitive-specific x509 / jwt flags. Probably spire-server.md also needs updating on this removal.

@heymarcel
Copy link
Contributor

I'm working on this issue.

heymarcel added a commit to heymarcel/spire that referenced this issue Sep 9, 2024
@heymarcel
Remove deprecated -ttl flag from spire server cli
f136249 
This commit removes the deprecated `-ttl` flag from `spire entry
create` and `spire entry update`. Docs are also updated.

See discussion in spiffe#5254

Signed-off-by: Marcel Levy <marcel@spirl.com>
@heymarcel heymarcel mentioned this issue Sep 9, 2024
Merged
3 tasks
@heymarcel
Copy link
Contributor

I've opened a PR: #5483

heymarcel added a commit to heymarcel/spire that referenced this issue Sep 12, 2024
@heymarcel
Remove deprecated -ttl flag from spire server cli
bd09c35 
This commit removes the deprecated `-ttl` flag from `spire entry
create` and `spire entry update`. Docs are also updated.

See discussion in spiffe#5254

Signed-off-by: Marcel Levy <marcel@spirl.com>
amartinezfayo pushed a commit that referenced this issue Sep 12, 2024
@heymarcel @MarcosDY
Remove deprecated -ttl flag from spire server cli (#5483)
32eaeca 
* Remove deprecated -ttl flag from spire server cli

This commit removes the deprecated `-ttl` flag from `spire entry
create` and `spire entry update`. Docs are also updated.

See discussion in #5254

Signed-off-by: Marcel Levy <marcel@spirl.com>

* Remove -ttl from integration tests

Signed-off-by: Marcel Levy <marcel@spirl.com>

* Fix windows unit test

Signed-off-by: Marcel Levy <marcel@spirl.com>

---------

Signed-off-by: Marcel Levy <marcel@spirl.com>
Co-authored-by: Marcos Yacob <marcos.yacob@hpe.com>
@azdagron
Copy link
Member Author

Resolved by #5483.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
4 participants
@heymarcel @azdagron @amoore877 @ayushrakesh