Replace golint to revive #2315
Merged
Replace golint to revive #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomoya Usami <tousami@zlab.co.jp>
hiyosi
requested review from
amartinezfayo,
APTy,
azdagron,
evan2645 and
rturner3
as code owners
|
Looks like it is deprecated from 1.41, do you tried to upgrade golanglint to that version? |
MarcosDY
reviewed
May 21, 2021
| # minimal confidence for issues, default is 0.8 | ||
| min-confidence: 0.0 | ||
| confidence: 0.0 |
There was a problem hiding this comment.
may we add ignoreGeneratedHeader = true?
oh, you are right. Once I tried to upgrade the version, I find that there is a bug. I guess it's better to wait for the bug to be fixed. |
azdagron
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomoya Usami tousami@zlab.co.jp
Pull Request check list
Affected functionality
linters
Description of change
Use
reviveinstead ofgolintSince
golinthas been deprecated(thegolintrepository has already been archived), I think it is better to replace.reviveis mentioned by the golangci-lint doc.https://golangci-lint.run/usage/linters/
What do you think about this code style? Is it acceptable?
Which issue this PR fixes
#2198
@MarcosDY may also be working on same as this. Please comment if you have any concerns.