Update MaxConnections default value #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FedeNQ <fedenahuel07@gmail.com>
FedeNQ
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
MarcosDY
approved these changes
Nov 22, 2023
faisal-memon
pushed a commit
to faisal-memon/spire
that referenced
this pull request
Dec 2, 2023
Signed-off-by: FedeNQ <fedenahuel07@gmail.com> Signed-off-by: Faisal Memon <fymemon@yahoo.com>
sorindumitru
added a commit
to sorindumitru/spire
that referenced
this pull request
Jan 10, 2024
Max open connections default value was changed in spiffe#4656 to 100 Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
3 tasks
azdagron
pushed a commit
that referenced
this pull request
Jan 10, 2024
Max open connections default value was changed in #4656 to 100 Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
sriyer
pushed a commit
to spire-vault/spire
that referenced
this pull request
Feb 23, 2024
Max open connections default value was changed in spiffe#4656 to 100 Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
Max open connections default value was changed in spiffe#4656 to 100 Signed-off-by: Sorin Dumitru <sdumitru@bloomberg.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Default value in max_open_connections
Description of change
In order to avoid an "infinite" numbers of connections, the default value is now set to 100.
In other hand, is recommended to keep the default value of connection lifetime as it is now, because in most cases recreate the connection is too slow, and keep it alive isn't a problem.
Which issue this PR fixes
fixes #4300