Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the mt entity #105

Closed
wants to merge 1 commit into from
Closed

Use the mt entity #105

wants to merge 1 commit into from

Conversation

kousu
Copy link
Contributor

@kousu kousu commented Nov 16, 2021

Before https://bids-specification.readthedocs.io/en/stable/99-appendices/09-entities.html#mt
was standardized, we'd encoded this information in the acq field. But
now we don't have to.

This was done with this script:

find . -name "*_acq-MT*.nii.gz" |
 while read fname; do
   git mv ${fname} ${fname/_acq-MT/_mt-};
 done

Fixes #103

@kousu
Use the mt entity
1b4f386 
Before https://bids-specification.readthedocs.io/en/stable/99-appendices/09-entities.html#mt
was standardized, we'd encoded this information in the acq field. But
now we don't have to.

This was done with this script:

```bash
find . -name "*_acq-MT*.nii.gz" |
 while read fname; do
   git mv ${fname} ${fname/_acq-MT/_mt-};
 done
```

Fixes #103
@kousu
Copy link
Contributor Author

kousu commented Nov 16, 2021

Despite my "fixes" claim, this doesn't yet deal with the acq-T1w ambiguity (#103 (comment)). Should we deal with that in this PR or in a follow up?

@kousu kousu mentioned this pull request Nov 16, 2021
Closed
jcohenadad
jcohenadad reviewed Nov 16, 2021
View reviewed changes
Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably need to also update the JSON fields

also we should open a PR in parallel in the analysis code so there is 'breaking' of the code

@kousu kousu mentioned this pull request Nov 16, 2021
Closed
@kousu kousu marked this pull request as draft November 16, 2021 03:46
@kousu
Copy link
Contributor Author

kousu commented Nov 16, 2021 •
edited
Loading

Drafted until it gets redone with mapping acq-T1w -> flip-2_mt-off: #103 (comment)

@alexfoias
Copy link
Contributor

@kousu @jcohenadad Can I take the lead on this PR since I addressed a series of other PRs in the last days? thanks

@mguaypaq
Copy link
Member

Fixed in #135 instead.

@mguaypaq mguaypaq closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcohenadad jcohenadad jcohenadad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

acq-MT{on,off} -> mt_{on,off}
4 participants
@kousu @alexfoias @mguaypaq @jcohenadad